[C] refactor client i18n #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgoff
added
documentation
|
A preview of this PR will be available at https://epo8564-dot-investigations-client-dot-skyviewer.appspot.com until the request is closed. |
|
A preview of this PR will be available at https://epo8564-dot-investigations-client-dot-skyviewer.appspot.com until the request is closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.lsstcorp.org/browse/EPO-8564
What this change does
Refactor client i18n to use a single i18next provider defined at the root level. Client components can now get their translations straight from the
react-i18nextuseTranslationhook. Removed prior uses of the dedicated client translation hook. Added language selector to menu. Added documentation for this setup toREADME.mdNotes for reviewers
Verify that language selector works and changes routing to new locale. Verify that client translation strings are translated and match the current locale.
Include an indication of how detailed a review you want on a 1-10 scale.
Checklist
If any of the following are true, please check them off
/src/data/pages/PAGE.json) or scientific data (anything in/static/) and I will notify Product Marketing when it is in prod and user visible.Screenshots (optional)
Before:
After: