Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[F] Implement bulk save mutation #60

Merged
merged 2 commits into from
Oct 12, 2023
Merged

[F] Implement bulk save mutation #60

merged 2 commits into from
Oct 12, 2023

Conversation

dananjohnson
Copy link
Contributor

@dananjohnson dananjohnson commented Oct 11, 2023

Resolves #52
Resolves #53

Note: this PR should be merged only after the corresponding PR in the API repo is merged.

What this change does

This PR updates the client to work with the new resolver in the API so that an entire answer set can be submitted for an investigation in one mutation.

It also adds logic to handle user accounts in a pending state. In such cases, the Save Your Work button is be disabled and a message is shown to users to activate their account. The mutation will also not run, should someone still find a way to submit the form.

Notes for reviewers

Include an indication of how detailed a review you want on a 1-10 scale.

  • 5 = "Please make sure there are no obvious errors and that you believe it does what it says it does"

Checklist

If any of the following are true, please check them off

  • This is a breaking change: changes in page data (/src/data/pages/PAGE.json) or scientific data (anything in /static/) and I will notify Product Marketing when it is in prod and user visible.
  • This change impacts several investigations (e.g. the change affects reuseed styles, widgets, pages, QAs, utility methods, etc.)
  • This change is isolated to a specific page or Component (i.e. it's a one-off)
  • I don't know what this change does

@dananjohnson dananjohnson requested a review from blnkt October 11, 2023 19:24
@github-actions
Copy link

A preview of this PR will be available at https://dj53-dot-investigations-client-dot-skyviewer.appspot.com until the request is closed.

@github-actions
Copy link

A preview of this PR will be available at https://dj53-dot-investigations-client-dot-skyviewer.appspot.com until the request is closed.

@blnkt blnkt merged commit 920fea1 into develop Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants