chore(release) #294
Merged
chore(release) #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A preview of this PR will be available at https://develop-dot-investigations-client-dot-edc-int-6c5e.uc.r.appspot.com until the request is closed. |
1 similar comment
|
A preview of this PR will be available at https://develop-dot-investigations-client-dot-edc-int-6c5e.uc.r.appspot.com until the request is closed. |
Co-authored-by: Jared Trouth <[email protected]>
Co-authored-by: Jared Trouth <[email protected]>
Co-authored-by: Jared Trouth <[email protected]> Co-authored-by: Eric Rosas <[email protected]>
|
A preview of this PR will be available at https://develop-dot-investigations-client-dot-edc-int-6c5e.uc.r.appspot.com until the request is closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.lsstcorp.org/browse/
What this change does
A few sentences describing the outcome of the change (“fixes a thing”; "adds the stuff") and how you tackled it (“added a prop to prevent lazyloading in the presence of barbara walters”). How successful is the change? And how are you measuring that success?
Notes for reviewers
Where should the reviewer look for the change? Do they review the change on the frontend? How extensive is the change? Does it affect Components used in a variety of contexts? Anything you'd like reviewers to pay particular attention to or questions you have about the change.
Include an indication of how detailed a review you want on a 1-10 scale.
Testing
How did you test this change? Can the reviewer test this change for themselves?
If you wrote new tests in the change it's fine to just put "New tests in PR". If you haven't added any tests but you think your change is covered by existing tests you can say "Existing tests". And if you're not sure how to test it, say that.
Checklist
If any of the following are true, please check them off
/src/data/pages/PAGE.json) or scientific data (anything in/static/) and I will notify Product Marketing when it is in prod and user visible.Screenshots (optional)
Before:
After: