Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #287

Closed
wants to merge 3 commits into from
Closed

Develop #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39cc15a
K8s updates (#280)
jtrouth Oct 17, 2024
888160f
Bugfix/workflow branch (#286)
jrosati-burwood Oct 21, 2024
9f33960
change app name for k8s image (#288)
jrosati-burwood Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/build-and-push.yaml
View file
Open in desktop
jrosati-burwood marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
branches:
- "develop"
- "master"
- 'main'
tags:
- "v*"

Expand Down Expand Up @@ -88,6 +89,7 @@ jobs:
type=gha
build-args: |
BASE_TAG=k8s
RUN_BUILD=false
- name: Summary
run: |
cat <<-EOT >> "$GITHUB_STEP_SUMMARY"
Expand All @@ -110,7 +112,7 @@ jobs:
api.image.repository=${{ needs.build.outputs.image_name }}
)
DATA="{
\"app_name\": \"investigations-client\",
\"app_name\": \"investigations\",
\"environment_name\": \"${{ needs.build.outputs.environment_name }}\",
\"parameters\": $(jq -c -n '$ARGS.positional' --args ${PARAMETERS[@]})
}"
Expand Down
7 changes: 6 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,17 @@
ARG NEXT_PUBLIC_API_URL
ARG NEXT_PUBLIC_BASE_URL
ARG NEXT_PUBLIC_GOOGLE_APP_ID
ARG GOOGLE_APP_SECRET

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / Build Container Image

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "GOOGLE_APP_SECRET")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
ARG CRAFT_SECRET_TOKEN

Check warning on line 15 in Dockerfile

View workflow job for this annotation

GitHub Actions / Build Container Image

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "CRAFT_SECRET_TOKEN")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
ARG CRAFT_EDUCATOR_SCHEMA_SECRET_TOKEN

Check warning on line 16 in Dockerfile

View workflow job for this annotation

GitHub Actions / Build Container Image

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "CRAFT_EDUCATOR_SCHEMA_SECRET_TOKEN")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
ARG CRAFT_STUDENT_SCHEMA_SECRET_TOKEN

Check warning on line 17 in Dockerfile

View workflow job for this annotation

GitHub Actions / Build Container Image

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "CRAFT_STUDENT_SCHEMA_SECRET_TOKEN")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

RUN npx browserslist@latest --update-db && yarn static:build
RUN npx browserslist@latest --update-db

ARG RUN_BUILD="true"
ENV RUN_BUILD=${RUN_BUILD}

RUN if $RUN_BUILD;then yarn static:build;fi

# Production image, copy all the files and run next
FROM node:20-alpine AS runner
Expand Down
Loading