Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed widget sizes #187

Merged
merged 4 commits into from
May 8, 2024
Merged

Fixed widget sizes #187

merged 4 commits into from
May 8, 2024

Conversation

alexgoff
Copy link
Contributor

@alexgoff alexgoff commented May 3, 2024

What this change does

Implement the widgets that are fitted to aspect ratio containers into the Investigations, and set up using the heights of the nav/pager/other page elements to determine final size.

Checklist

If any of the following are true, please check them off

  • This is a breaking change: changes in page data (/src/data/pages/PAGE.json) or scientific data (anything in /static/) and I will notify Product Marketing when it is in prod and user visible.
  • This change impacts several investigations (e.g. the change affects reuseed styles, widgets, pages, QAs, utility methods, etc.)
  • This change is isolated to a specific page or Component (i.e. it's a one-off)
  • I don't know what this change does

Screenshots (optional)

image
image
image
image
image

@alexgoff alexgoff added bug Something isn't working enhancement New feature or request labels May 3, 2024
@alexgoff alexgoff self-assigned this May 3, 2024
@alexgoff alexgoff force-pushed the agoff/fixed-widget-sizes branch from 420148e to 4895f0e Compare May 3, 2024 21:08
Copy link

github-actions bot commented May 3, 2024

A preview of this PR will be available at https://agofffixedwidgetsizes-dot-investigations-client-dot-skyviewer.uw.r.appspot.com until the request is closed.

Copy link

github-actions bot commented May 8, 2024

A preview of this PR will be available at https://agofffixedwidgetsizes-dot-investigations-client-dot-skyviewer.uw.r.appspot.com until the request is closed.

@alexgoff alexgoff merged commit 7f23d68 into develop May 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant