Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validated number questions in multipart type #184

Merged
merged 6 commits into from
May 6, 2024

Conversation

alexgoff
Copy link
Contributor

@alexgoff alexgoff commented May 2, 2024

What this change does

Add validated numbers to multipart questions and do some cleanup and extraction of multipart questions

Notes for reviewers

Client + API changes

Testing

  • Create a multipart question in Craft, add a number with validations
  • Observe on the page that validations work as intended (additionally check a standalone number question to see that it also still works)
  • Observe that the question also displays in the review page and in XLSX

Resolves #171

@alexgoff alexgoff added the enhancement New feature or request label May 2, 2024
@alexgoff alexgoff self-assigned this May 2, 2024
Copy link

github-actions bot commented May 2, 2024

A preview of this PR will be available at https://agmultipartvalidations-dot-investigations-client-dot-skyviewer.uw.r.appspot.com until the request is closed.

@alexgoff alexgoff merged commit b24e2ed into develop May 6, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant