-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of Flake8 action #101
Conversation
Initial implementation of Flake8 action
Resolves #100 |
Explicitly setting other package validation to false
Confirming config file is created as expected
Fixed config file creation issue
Trying out a relative path for config file
Moved config file to home dir with cat
Seeing if a `.flake8` file in the repo will be picked up
Fixed Flake8 validation errors in `utils.py`
Fixed more validation errors
Adding explicit jupyter notebook run
Added separate step to run notebook validation
Trying new Github action
Adding back .py validation
Split out py script and notebook validation to their own jobs
Excluding `experimental_notebooks` folder in Flake8 config
@beckynevin We'll need to figure out what to do about the notebooks in the There are a few options:
Let me know your thoughts when you have a moment. |
Quick ignore test
Removed test config rule
You fixed this right? Because I currently don't see them being reviewed in the action.
This looks like it was resolved, right? I can't quite tell when I'm looking at the validate action for notebooks which notebook it's looking at but it looks like you solved this and now it's just looking within the main folder right? |
Upped `mhitza/flake8-jupyter-notebook` action minor version number
Trying glob pattern in `.flake8` exclude prop
Explicit `exclude` paths in `.flake8`
Renamed experimental notebooks file ext
Fixed MacOS's annoying handling of file exts
Initial implementation of Flake8 action