-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new cp_pipe pipelines and new IsrTaskLSST #96
Open
jchiang87
wants to merge
16
commits into
main
Choose a base branch
from
u/jchiang/isrTaskLSST
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchiang87
force-pushed
the
u/jchiang/isrTaskLSST
branch
2 times, most recently
from
October 24, 2024 05:14
e899cef
to
58c06f0
Compare
jchiang87
force-pushed
the
u/jchiang/isrTaskLSST
branch
2 times, most recently
from
November 12, 2024 20:52
97d702c
to
e45d6d3
Compare
…f making combined darks and flats
…ordering to account for bootstrap and other new pipelines
…ml but comment out transmission curve stuff until it's ready
…nearity corrections applied
…eled by ticket number
jchiang87
force-pushed
the
u/jchiang/isrTaskLSST
branch
from
November 16, 2024 04:13
e45d6d3
to
af6eb96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
cp_pipe
pipelines according to DM-45856[cpBias,cpDark,cpFlat]Bootstrap
versionscpLinearizer
pipeline as a precursor tocpPtc
cpDefects
pipeline (which now builds combined darks and flats)cp_pipe
ISR configs, includingdoCrosstalk=True
,doLinearize=True
where relevant.cpBfk
since the BF kernels aren't used byeo_pipe
cpBias
,cpDark
,cpFlat
IsrTaskLSST
into bias stability code and replaceIsrTask
steps in variouseo_pipe
pipelineslinearizerPtc
as input toeoLinearityPlots
pipelinecp_pipe
combined darks and flats as inputs toeo[Bright,Dark]Defects
pipelines instead of building combined frames in theeo_pipe
pipelines.Because of the
cp_pipe
re-ordering, in the runtime environment set up, the top-level input collection to theeo_pipe
pipelines will need to befor PTC runs and
for B-protocol runs, instead of
which could be used for all runs.