Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: convert Rust errors into JS errors #18

Merged
merged 1 commit into from
Dec 24, 2023
Merged

fix: convert Rust errors into JS errors #18

merged 1 commit into from
Dec 24, 2023

Conversation

tomquist
Copy link
Contributor

@tomquist tomquist commented Dec 23, 2023 •
edited
Loading

This makes it so the APIs throw errors instead of panicking.

Thanks for creating this wrapper! It's incredibly fast but the lack of error handling makes it impractical to use.

@tomquist
Don't Panic: Convert rust errors into JS errors
7b3ba3c 
This makes it so the APIs throw errors instead of panicking.
@lsndr lsndr changed the title Don't Panic: Convert rust errors into JS errors fix: convert Rust errors into JS errors Dec 24, 2023
@lsndr lsndr self-requested a review December 24, 2023 07:45
@lsndr lsndr added the bug Something isn't working label Dec 24, 2023
@lsndr lsndr merged commit 4269af4 into lsndr:master Dec 24, 2023
29 of 31 checks passed
@lsndr
Copy link
Owner

lsndr commented Dec 24, 2023

Thank you!

@tomquist tomquist deleted the dont-panic branch December 28, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsndr lsndr Awaiting requested review from lsndr

Assignees

@tomquist tomquist

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomquist @lsndr