Kokkos-free einspline reference implementation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check_spo compiles and runs - but fails with a large error. Probably due to spo initialization order mis-match between ref and kokkos. See the differences between the set() methods for the Kokkos and ref implementations.
Turns out I'm a dummy and had a fencepost error in the calculation of the error between the reference and kokkos implementations. Changing a "6" to a "5" fixed the problem, and now check_spo passes on both power9, and V100 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements a Kokkos-free einspline reference.
The major changes include:
check_spo compiles and passes on both Power9 and V100 devices!