Updated Cmakelists.txt #212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slightly modified the cake configuration to make it easier to use the library in downstream code: should be able to #include "enet/enet.h" without any special IDE configuration.
h3xx
reviewed
Dec 4, 2023
| target_include_directories(enet PUBLIC ${PROJECT_SOURCE_DIR}/include) # define the public header files path | ||
| # consuming projects should be able to do #include "enet/enet.h" in their IDE (tested with CLion) | ||
|
|
||
| file(COPY ${INCLUDE_FILES_PREFIX}/enet.h DESTINATION "include") # Copy the public header file to the build include directory for convenience |
There was a problem hiding this comment.
This copies the enet.h file to wherever ${CMAKE_CURRENT_BINARY_DIR}/include points to, but it does it during the configuration step, not when installing.
|
This looks like a wrong approach for me. enet is installing the headers already when doing a cmake install, doing this additionally during a configure steps looks very wrong to me. Line 101 in 276ff5a This can probably be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly modified the cake configuration to make it easier to use the library in downstream code: should be able to #include "enet/enet.h" without any special IDE configuration.
Also added a copy of enet.h to the build directory (within an include directory) as a small convenience.