Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix Update JBCefBrowser and enable cache to work everywhere. #100

Merged
merged 6 commits into from
Mar 15, 2024
Merged

Bugfix Update JBCefBrowser and enable cache to work everywhere. #100

merged 6 commits into from
Mar 15, 2024

Conversation

GunniBusch
Copy link
Contributor

@GunniBusch GunniBusch commented Dec 8, 2023 •
edited
Loading

Motivation and Context

Sometimes Orion does not stay logged in (like on Macs)

Description

Removed the manual Cache path allocation. That is already done by the JetBrains wrapper.
Cache is done by JBCefAppCache.
Resolves #55

Steps for Testing

  1. Install the release as described in the readme
  2. Open an exercise in Orion
  3. Close IntelliJ
  4. Reopen IntelliJ
  5. Be fascinated that you don't have to log back in.

Review Progress

Code Review

  • Review 1
  • Review 2

Manual Tests

  • Test 1
  • Test 2

Screenshots

@GunniBusch GunniBusch mentioned this pull request Dec 9, 2023
Closed
@Kroko-fant Kroko-fant changed the title Update JBCefBrowser and enable cache to work everywhere. Bugfix Update JBCefBrowser and enable cache to work everywhere. Dec 10, 2023
Kroko-fant
Kroko-fant previously approved these changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@Kroko-fant Kroko-fant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes look good to me. The OrionTemplateDiffEditorProvidor change might need refactoring in the future but the code works well for now.

src/main/java/de/tum/www1/orion/ui/assessment/OrionTemplateDiffEditorProvider.kt Outdated Show resolved Hide resolved
@Kroko-fant Kroko-fant mentioned this pull request Dec 10, 2023
Merged
4 tasks
@GunniBusch
Copy link
Contributor Author

GunniBusch commented Dec 11, 2023 •
edited
Loading

The proposed changes look good to me. The OrionTemplateDiffEditorProvidor change might need refactoring in the future but the code works well for now.

@Kroko-fant Done with GunniBusch@f7dc39c in #99

Kroko-fant
Kroko-fant approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@Kroko-fant Kroko-fant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me. Code looks good to me.

@Kroko-fant Kroko-fant merged commit 40f3400 into ls1intum:main Mar 15, 2024
4 checks passed
@GunniBusch GunniBusch deleted the Enhancement-Save-Logins-everywhere branch March 16, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kroko-fant Kroko-fant Kroko-fant approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storing Credentials does not work reliably with runIDE
2 participants
@GunniBusch @Kroko-fant