Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:Module programming llm #341

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Fix:Module programming llm #341

merged 3 commits into from
Sep 16, 2024

Conversation

undernagruzez
Copy link
Contributor

@undernagruzez undernagruzez commented Sep 14, 2024

Motivation and Context

Due to a miscommunication, the environment variables and model configurations were altered, leading to issues with the module setup in module_programming_llm. This PR aims to resolve the misconfiguration by correctly setting the environment variable names and ensuring the appropriate model setup script is utilized.

Description

Updated the environment variables to reflect the correct names.
Linked the model setup script to the correct configuration.
Validated the changes to ensure seamless integration with the module_programming_llm.

Steps for Testing

Deploy and try to send a submission to module_programming_llm.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.


Screenshots

# Conflicts:
#	modules/programming/module_programming_llm/module_programming_llm/helpers/models/openai.py
@undernagruzez undernagruzez added the deploy:athena-test2 Athena Test Server 2 label Sep 14, 2024
@github-actions github-actions bot removed the deploy:athena-test2 Athena Test Server 2 label Sep 14, 2024
Copy link

⚠️ Unable to deploy to test servers ⚠️

The docker build needs to run through before deploying.

@github-actions github-actions bot added the deployment-error Added by deployment workflows if an error occured label Sep 14, 2024
@undernagruzez undernagruzez added deploy:athena-test2 Athena Test Server 2 and removed deployment-error Added by deployment workflows if an error occured labels Sep 14, 2024
@undernagruzez undernagruzez temporarily deployed to athena-test2.ase.cit.tum.de September 14, 2024 22:26 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:athena-test2 Is currently deployed to Athena Test Server 2 and removed deploy:athena-test2 Athena Test Server 2 labels Sep 14, 2024
@undernagruzez undernagruzez added deploy:athena-test2 Athena Test Server 2 and removed lock:athena-test2 Is currently deployed to Athena Test Server 2 labels Sep 15, 2024
@undernagruzez undernagruzez temporarily deployed to athena-test2.ase.cit.tum.de September 15, 2024 18:12 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:athena-test2 Is currently deployed to Athena Test Server 2 and removed deploy:athena-test2 Athena Test Server 2 labels Sep 15, 2024
@undernagruzez undernagruzez added deploy:athena-test2 Athena Test Server 2 and removed lock:athena-test2 Is currently deployed to Athena Test Server 2 labels Sep 16, 2024
@undernagruzez undernagruzez temporarily deployed to athena-test2.ase.cit.tum.de September 16, 2024 07:26 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:athena-test2 Is currently deployed to Athena Test Server 2 and removed deploy:athena-test2 Athena Test Server 2 labels Sep 16, 2024
@undernagruzez undernagruzez removed the lock:athena-test2 Is currently deployed to Athena Test Server 2 label Sep 16, 2024
@undernagruzez undernagruzez added the deploy:athena-test2 Athena Test Server 2 label Sep 16, 2024
@undernagruzez undernagruzez temporarily deployed to athena-test2.ase.cit.tum.de September 16, 2024 08:29 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:athena-test2 Is currently deployed to Athena Test Server 2 and removed deploy:athena-test2 Athena Test Server 2 labels Sep 16, 2024
@undernagruzez undernagruzez removed the lock:athena-test2 Is currently deployed to Athena Test Server 2 label Sep 16, 2024
@undernagruzez undernagruzez changed the title Fix/programming llm FixModule programming llm Sep 16, 2024
@undernagruzez undernagruzez changed the title FixModule programming llm Fix:Module programming llm Sep 16, 2024
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, hopefully we will fix such inconvenience soon through a shared llm library. The module worked for me on TS2

@FelixTJDietrich FelixTJDietrich merged commit bbbcbc9 into develop Sep 16, 2024
22 checks passed
@FelixTJDietrich FelixTJDietrich deleted the fix/programming-llm branch September 16, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants