Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared llm package refactoring #336

Merged
merged 18 commits into from
Oct 11, 2024
Merged

Shared llm package refactoring #336

merged 18 commits into from
Oct 11, 2024

Conversation

EneaGore
Copy link
Contributor

@EneaGore EneaGore commented Sep 2, 2024

Motivation and Context

Description

Steps for Testing

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.


Screenshots

@EneaGore EneaGore force-pushed the development/shared_llm_package branch from 153fe73 to afd737f Compare October 7, 2024 03:11
@EneaGore EneaGore added the deploy:athena-test2 Athena Test Server 2 label Oct 7, 2024
@EneaGore EneaGore temporarily deployed to athena-test2.ase.cit.tum.de October 7, 2024 04:27 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:athena-test2 Is currently deployed to Athena Test Server 2 and removed deploy:athena-test2 Athena Test Server 2 labels Oct 7, 2024
@EneaGore EneaGore added deploy:athena-test2 Athena Test Server 2 and removed lock:athena-test2 Is currently deployed to Athena Test Server 2 labels Oct 7, 2024
@EneaGore EneaGore temporarily deployed to athena-test2.ase.cit.tum.de October 7, 2024 16:02 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:athena-test2 Is currently deployed to Athena Test Server 2 and removed deploy:athena-test2 Athena Test Server 2 labels Oct 7, 2024
@EneaGore EneaGore added deploy:athena-test2 Athena Test Server 2 and removed lock:athena-test2 Is currently deployed to Athena Test Server 2 labels Oct 7, 2024
@EneaGore EneaGore temporarily deployed to athena-test2.ase.cit.tum.de October 7, 2024 19:55 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:athena-test2 Is currently deployed to Athena Test Server 2 and removed deploy:athena-test2 Athena Test Server 2 labels Oct 7, 2024
@EneaGore EneaGore added deploy:athena-test2 Athena Test Server 2 and removed lock:athena-test2 Is currently deployed to Athena Test Server 2 labels Oct 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

⚠️ Unable to deploy to test servers ⚠️

The docker build needs to run through before deploying.

@github-actions github-actions bot added deployment-error Added by deployment workflows if an error occured and removed deploy:athena-test2 Athena Test Server 2 labels Oct 7, 2024
@EneaGore EneaGore added deploy:athena-test2 Athena Test Server 2 and removed deployment-error Added by deployment workflows if an error occured labels Oct 7, 2024
@EneaGore EneaGore temporarily deployed to athena-test2.ase.cit.tum.de October 7, 2024 20:44 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:athena-test2 Is currently deployed to Athena Test Server 2 and removed deploy:athena-test2 Athena Test Server 2 labels Oct 7, 2024
@EneaGore EneaGore marked this pull request as ready for review October 7, 2024 20:48
@EneaGore EneaGore added deploy:athena-test2 Athena Test Server 2 and removed lock:athena-test2 Is currently deployed to Athena Test Server 2 labels Oct 9, 2024
@EneaGore EneaGore temporarily deployed to athena-test2.ase.cit.tum.de October 9, 2024 23:21 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:athena-test2 Is currently deployed to Athena Test Server 2 and removed deploy:athena-test2 Athena Test Server 2 labels Oct 9, 2024
dmytropolityka
dmytropolityka approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@dmytropolityka dmytropolityka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on ts2

LeonWehrhahn
LeonWehrhahn approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@LeonWehrhahn LeonWehrhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good - Also now with the restructured utils folder

FelixTJDietrich
FelixTJDietrich reviewed Oct 11, 2024
View reviewed changes
modules/llm_core/llm_core/utils/predict_and_parse.py
prompt_input: dict,
pydantic_object: Type[T],
model: BaseLanguageModel,
chat_prompt: ChatPromptTemplate,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add formatting instructions now if you use predict_and_parse with get_chat_prompt_with_formatting_instructions. It might also make sense to already include it predict_and_parse

@FelixTJDietrich FelixTJDietrich removed the lock:athena-test2 Is currently deployed to Athena Test Server 2 label Oct 11, 2024
FelixTJDietrich
FelixTJDietrich approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great job! I hope this will make things easier in the future 🎉

@FelixTJDietrich FelixTJDietrich merged commit 9521121 into develop Oct 11, 2024
22 of 23 checks passed
@FelixTJDietrich FelixTJDietrich deleted the development/shared_llm_package branch October 11, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelixTJDietrich FelixTJDietrich FelixTJDietrich approved these changes

@LeonWehrhahn LeonWehrhahn LeonWehrhahn approved these changes

@dmytropolityka dmytropolityka dmytropolityka approved these changes

Assignees

@EneaGore EneaGore

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EneaGore @FelixTJDietrich @dmytropolityka @LeonWehrhahn