-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Playground #284
Upgrade Playground #284
Conversation
Bumps [next](https://github.com/vercel/next.js) from 13.5.6 to 14.1.1. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v13.5.6...v14.1.1) --- updated-dependencies: - dependency-name: next dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [mysql2](https://github.com/sidorares/node-mysql2) from 3.9.7 to 3.9.8. - [Release notes](https://github.com/sidorares/node-mysql2/releases) - [Changelog](https://github.com/sidorares/node-mysql2/blob/master/Changelog.md) - [Commits](sidorares/node-mysql2@v3.9.7...v3.9.8) --- updated-dependencies: - dependency-name: mysql2 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
…nd/next-14.1.1' into feature/playground-self-learning-feedback
…nd/mysql2-3.9.8' into feature/playground-self-learning-feedback
Why is the prospector linting check failing? Can we fix this in a follow-up, I will create an issue.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, works as expected on the test server. I will merge it now.
This is because we use different versions of langchain for different llm modules. We cannot fix it now but this issue will disappear when we decouple modules from the top-level module(I will create a PR by tomorrow). |
Motivation and Context
Playground was not extended to support self-learning feedback generation, although this feature exists.
Also, this PR #280 changed some internals and changed Authentication.
Playground was not affected. This PR fixes that.
Description
Steps for Testing
Deploy the testing setup on the ts or locally. Submit new self-learning-feedback requests and old graded requests. Verify everything works.
For local, the key is empty. For athena ts3, the key is here: https://confluence.ase.in.tum.de/pages/viewpage.action?pageId=25252245
Screenshots