Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Playground #284

Merged
merged 54 commits into from
Jul 26, 2024
Merged

Conversation

dmytropolityka
Copy link
Contributor

@dmytropolityka dmytropolityka commented Jun 3, 2024

Motivation and Context

Playground was not extended to support self-learning feedback generation, although this feature exists.
Also, this PR #280 changed some internals and changed Authentication.
Playground was not affected. This PR fixes that.

Description

  1. Renamed all URL fields into uri fields to stay consistent with Artemis.
  2. Added deployment information about Playground to enable support for new Authentication.
  3. Updated nodejs version for docker images.
  4. Added lms(client) URL field to the playground header.
  5. Chaned athena fetcher to modify the authorization headers in Playground client.
  6. Chaned Playground server to forward these headers.
  7. Removed unnecessary yarn lock file.

Steps for Testing

Deploy the testing setup on the ts or locally. Submit new self-learning-feedback requests and old graded requests. Verify everything works.
For local, the key is empty. For athena ts3, the key is here: https://confluence.ase.in.tum.de/pages/viewpage.action?pageId=25252245

Screenshots

image

dependabot bot and others added 26 commits May 10, 2024 01:55
Bumps [next](https://github.com/vercel/next.js) from 13.5.6 to 14.1.1.
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](vercel/next.js@v13.5.6...v14.1.1)

---
updated-dependencies:
- dependency-name: next
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [mysql2](https://github.com/sidorares/node-mysql2) from 3.9.7 to 3.9.8.
- [Release notes](https://github.com/sidorares/node-mysql2/releases)
- [Changelog](https://github.com/sidorares/node-mysql2/blob/master/Changelog.md)
- [Commits](sidorares/node-mysql2@v3.9.7...v3.9.8)

---
updated-dependencies:
- dependency-name: mysql2
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
…nd/next-14.1.1' into feature/playground-self-learning-feedback
…nd/mysql2-3.9.8' into feature/playground-self-learning-feedback
@github-actions github-actions bot added the lock:athena-test1 Is currently deployed to Athena Test Server 1 label Jul 24, 2024
@github-actions github-actions bot added the deployment-error Added by deployment workflows if an error occured label Jul 24, 2024
@maximiliansoelch maximiliansoelch added deploy:athena-test1 Athena Test Server 1 and removed lock:athena-test1 Is currently deployed to Athena Test Server 1 deployment-error Added by deployment workflows if an error occured labels Jul 24, 2024
@github-actions github-actions bot added lock:athena-test1 Is currently deployed to Athena Test Server 1 and removed deploy:athena-test1 Athena Test Server 1 labels Jul 24, 2024
@dmytropolityka dmytropolityka added deploy:athena-test1 Athena Test Server 1 and removed lock:athena-test1 Is currently deployed to Athena Test Server 1 labels Jul 26, 2024
@dmytropolityka dmytropolityka self-assigned this Jul 26, 2024
@github-actions github-actions bot added lock:athena-test1 Is currently deployed to Athena Test Server 1 and removed deploy:athena-test1 Athena Test Server 1 labels Jul 26, 2024
@FelixTJDietrich
Copy link
Collaborator

Why is the prospector linting check failing? Can we fix this in a follow-up, I will create an issue.

Run echo "$HOME/.local/bin" >> $GITHUB_PATH
Creating virtualenv athena-modularized-tH5MAedG-py3.11 in /home/runner/.cache/pypoetry/virtualenvs
Installing dependencies from lock file

pyproject.toml changed significantly since poetry.lock was last generated. Run `poetry lock [--no-update]` to fix the lock file.

Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, works as expected on the test server. I will merge it now.

@FelixTJDietrich FelixTJDietrich merged commit 63f08fc into develop Jul 26, 2024
17 of 18 checks passed
@FelixTJDietrich FelixTJDietrich deleted the feature/playground-self-learning-feedback branch July 26, 2024 09:31
@dmytropolityka
Copy link
Contributor Author

Why is the prospector linting check failing? Can we fix this in a follow-up, I will create an issue.

Run echo "$HOME/.local/bin" >> $GITHUB_PATH
Creating virtualenv athena-modularized-tH5MAedG-py3.11 in /home/runner/.cache/pypoetry/virtualenvs
Installing dependencies from lock file

pyproject.toml changed significantly since poetry.lock was last generated. Run `poetry lock [--no-update]` to fix the lock file.

This is because we use different versions of langchain for different llm modules. We cannot fix it now but this issue will disappear when we decouple modules from the top-level module(I will create a PR by tomorrow).

@dmytropolityka dmytropolityka removed the lock:athena-test1 Is currently deployed to Athena Test Server 1 label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants