Skip to content

Commit

Permalink
Development: Remove deployments info from docker image and inject it …
Browse files Browse the repository at this point in the history
…via volumes during docker compose (#329)
  • Loading branch information
maximiliansoelch authored Aug 12, 2024
1 parent b1ba652 commit 584e154
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 12 deletions.
4 changes: 0 additions & 4 deletions assessment_module_manager/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,5 @@ COPY . ./
RUN cp ./modules.docker.ini ./modules.ini
RUN rm ./modules.docker.ini

# Use deployments configuration file for docker
RUN cp ./deployments.docker.ini ./deployments.ini
RUN rm ./deployments.docker.ini

# poetry scripts don't work here
CMD poetry run python -m assessment_module_manager
8 changes: 0 additions & 8 deletions assessment_module_manager/deployments.docker.ini

This file was deleted.

1 change: 1 addition & 0 deletions assessment_module_manager/deployments.ini
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# for local development only

# local LMS instance, i.e. Artemis
[local]
url = http://localhost:8080

Expand Down
2 changes: 2 additions & 0 deletions docker-compose.prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ services:
depends_on:
- postgres
image: ls1tum/athena_assessment_module_manager:${ATHENA_TAG:-develop}
volumes:
- ./deployments.ini:/code/deployments.ini:ro

module_example:
hostname: module-example
Expand Down
2 changes: 2 additions & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ services:
- athena
ports:
- "5100:5100"
volumes:
- ./assessment_module_manager/deployments.ini:/code/deployments.ini:ro

module_example:
hostname: module-example
Expand Down

0 comments on commit 584e154

Please sign in to comment.