This check has been archived and is scheduled for deletion.
Learn more about checks retention
Teamscale / teamscale-findings
required action
Oct 15, 2023 in 0s
Teamscale
This pull request would introduce 118 new findings
Details
- src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#17: Star import of
de.tum.in.www1.artemis.domain.iris.message.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/iris/IrisMessageIntegrationTest.java#145: Clone with 2 instances of length 21 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#273: Method 'extractChanges' returns null instead of empty collection (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/websocket/IrisCodeEditorWebsocketService.java#68: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/web/rest/iris/IrisSessionResource.java#133: Clone with 2 instances of length 14 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/message/IrisMessageContent.java#22: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/websocket/IrisCodeEditorWebsocketService.java#61: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#48: Clone with 2 instances of length 16 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/web/rest/iris/IrisCodeEditorSessionResource.java#116: TODO (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorSessionIntegrationTest.java#49: Method
createSession_alreadyExistsviolates naming convention. Should be one of[a-z][a-zA-Z0-9]*(view in Teamscale) - src/main/java/de/tum/in/www1/artemis/web/rest/iris/IrisCodeEditorSessionResource.java#95: TODO (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#112: Violation of method length threshold (source lines of code) of 30: 32 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/web/rest/iris/IrisCodeEditorSessionResource.java#51: Method
IrisCodeEditorSessionResourcehas 8 parameters but no more than 7 parameters are allowed (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#256: Violation of nesting depth threshold of 3: 4 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/IrisConstants.java#118: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/message/ExerciseComponent.java#3: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/repository/iris/IrisCodeEditorSessionRepository.java#45: Clone with 2 instances of length 14 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/session/IrisCodeEditorSession.java#30: Empty block: constructor (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/util/IrisUtilTestService.java#16: Star import of
de.tum.in.www1.artemis.repository.*should not be used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#223: Violation of method length threshold (source lines of code) of 30: 42 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/web/rest/iris/IrisCodeEditorSessionResource.java#140: TODO for setting, but don't need to change the code here (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/util/IrisUtilTestService.java#140: Commented Out Code (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/message/IrisExercisePlanComponent.java#33: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/iris/IrisMessageIntegrationTest.java#57: Clone with 2 instances of length 16 (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/util/IrisUtilTestService.java#96: Clone with 3 instances of length 10 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/web/rest/iris/IrisCodeEditorMessageResource.java#154: Commented Out Code (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/util/IrisUtilTestService.java#95: Clone with 2 instances of length 19 (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#107: Clone with 2 instances of length 21 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/session/IrisCodeEditorSession.java#30: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/message/IrisMessageContent.java#9: Star import of
com.fasterxml.jackson.annotation.*should not be used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/domain/iris/message/IrisMessageContent.java#45: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorSessionIntegrationTest.java#68: Method
getCurrentSession_notFoundviolates naming convention. Should be one of[a-z][a-zA-Z0-9]*(view in Teamscale) - src/main/java/de/tum/in/www1/artemis/domain/iris/session/IrisCodeEditorSession.java#56: Avoid using ternary operators (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/web/rest/iris/IrisCodeEditorSessionResource.java#75: TODO (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#195: TODO: update AbstractIrisIntegrationTest.java later (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/web/rest/iris/IrisCodeEditorMessageResource.java#17: Star import of
de.tum.in.www1.artemis.repository.iris.*should not be used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#101: FIXME: Await update to Iris settings system (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/web/rest/iris/IrisCodeEditorSessionResource.java#136: Clone with 2 instances of length 14 (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#208: Clone with 2 instances of length 17 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/session/IrisChatSession.java#22: Clone with 2 instances of length 14 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/session/IrisChatSession.java#28: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/message/IrisExercisePlanMessageContent.java#77: Avoid using ternary operators (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/web/rest/iris/IrisCodeEditorMessageResource.java#42: Method
IrisCodeEditorMessageResourcehas 10 parameters but no more than 7 parameters are allowed (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/repository/iris/IrisExercisePlanComponentRepository.java#8: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#81: TODO: update AbstractIrisIntegrationTest.java later (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/util/IrisUtilTestService.java#95: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/message/IrisExercisePlanComponent.java#30: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/message/IrisTextMessageContent.java#28: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/util/IrisUtilTestService.java#124: Clone with 3 instances of length 10 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#288: Exception stacktrace is lost (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/web/rest/iris/IrisCodeEditorSessionResource.java#10: Star import of
org.springframework.web.bind.annotation.*should not be used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#261: Violation of nesting depth threshold of 3: 4 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#61: Method
IrisCodeEditorSessionServicehas 8 parameters but no more than 7 parameters are allowed (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#272: TODO: Implement (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/web/rest/iris/IrisChatMessageResource.java#36: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/web/rest/iris/IrisCodeEditorMessageResource.java#13: Star import of
de.tum.in.www1.artemis.domain.iris.message.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/iris/IrisMessageIntegrationTest.java#313: Clone with 2 instances of length 17 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/web/rest/iris/IrisCodeEditorMessageResource.java#124: TODO: Wait for requestExerciseChanges() (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/message/IrisMessageContent.java#29: Empty block: constructor (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#271: The value of parameter
contentis never used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/util/IrisUtilTestService.java#123: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#217: Clone with 3 instances of length 10 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/websocket/IrisCodeEditorWebsocketService.java#43: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#122: Avoid using ternary operators (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/web/rest/iris/IrisCodeEditorMessageResource.java#11: Star import of
org.springframework.web.bind.annotation.*should not be used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/domain/iris/message/IrisTextMessageContent.java#25: Empty block: constructor (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#49: Private field
irisSettingsServiceis never read (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/domain/iris/message/IrisExercisePlanComponent.java#14: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/websocket/IrisCodeEditorWebsocketService.java#57: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/session/IrisChatSession.java#31: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#124: FIXME: Template and model should be be configurable; await settings update (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/websocket/IrisCodeEditorWebsocketService.java#21: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/message/IrisMessage.java#95: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/websocket/IrisCodeEditorWebsocketService.java#17: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#178: TODO: update AbstractIrisIntegrationTest.java later (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/websocket/IrisCodeEditorWebsocketService.java#65: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#98: The value of parameter
ignoredis never used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#222: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#127: TODO: Consider refactoring this (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/message/IrisMessageContent.java#29: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/iris/IrisMessageIntegrationTest.java#21: Star import of
de.tum.in.www1.artemis.domain.iris.message.*should not be used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/web/rest/iris/IrisCodeEditorMessageResource.java#122: Commented Out Code (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/web/rest/iris/IrisChatMessageResource.java#11: Star import of
org.springframework.web.bind.annotation.*should not be used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/service/iris/websocket/IrisCodeEditorWebsocketService.java#83: Avoid using ternary operators (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/connectors/iris/dto/IrisMessageResponseV2DTO.java#9: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#141: TODO: wait for requestExerciseChanges() complete (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/session/IrisChatSession.java#28: Empty block: constructor (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/iris/IrisChatSessionIntegrationTest.java#20: Clone with 2 instances of length 28 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/repository/iris/IrisExercisePlanComponentRepository.java#10: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/web/rest/iris/IrisCodeEditorSessionResource.java#51: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/websocket/IrisChatWebsocketService.java#26: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/util/IrisUtilTestService.java#51: Clone with 3 instances of length 10 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/message/IrisMessageContent.java#32: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/message/IrisExercisePlanMessageContent.java#6: Star import of
javax.persistence.*should not be used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/domain/iris/session/IrisCodeEditorSession.java#33: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/repository/iris/IrisChatSessionRepository.java#45: Clone with 2 instances of length 14 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/message/IrisExercisePlanComponent.java#3: Star import of
javax.persistence.*should not be used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/repository/iris/IrisMessageContentRepository.java#16: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#231: TODO: Add prompt for each component (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/util/IrisUtilTestService.java#98: Clone with 4 instances of length 15 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/connectors/iris/IrisConnectorService.java#21: Star import of
de.tum.in.www1.artemis.service.connectors.iris.dto.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#20: Star import of
de.tum.in.www1.artemis.repository.iris.*should not be used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/web/rest/iris/IrisCodeEditorSessionResource.java#145: TODO (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/message/IrisExercisePlanComponent.java#30: Empty block: constructor (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/message/IrisMessageContent.java#4: Star import of
javax.persistence.*should not be used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/web/rest/iris/IrisCodeEditorMessageResource.java#42: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorSessionIntegrationTest.java#19: Clone with 2 instances of length 28 (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/util/IrisUtilTestService.java#50: Clone with 2 instances of length 19 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#16: Star import of
de.tum.in.www1.artemis.domain.*should not be used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/domain/iris/message/IrisMessageContent.java#11: Star import of
de.tum.in.www1.artemis.domain.*should not be used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/service/iris/IrisSessionService.java#74: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/websocket/IrisCodeEditorWebsocketService.java#71: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#3: Star import of
java.util.*should not be used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#61: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/websocket/IrisChatWebsocketService.java#20: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#18: Star import of
de.tum.in.www1.artemis.domain.iris.message.*should not be used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/domain/iris/session/IrisCodeEditorSession.java#24: Clone with 2 instances of length 14 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/iris/message/IrisTextMessageContent.java#25: Interface comment missing (view in Teamscale)
Annotations
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#L81
TODO: update AbstractIrisIntegrationTest.java later
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=09BB556D81F667EB07457204BF1D3C1A
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#L122
Avoid using ternary operators
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=4659EBADEA339323219A7294D6707FDE
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#L20
Star import of `de.tum.in.www1.artemis.repository.iris.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=46751E57BF45A78BEBB0CCBB8B208B83
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#L141
TODO: wait for requestExerciseChanges() complete
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=50D780B4988325663FC08296D59FE534
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#L48-L72
Clone with 2 instances of length 16
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=6B086722B5A36C8AF9D7627322136ED2
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#L107-L133
Clone with 2 instances of length 21
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=7FB1B8DE1B13D26EF968C1EA6615C1EC
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#L178
TODO: update AbstractIrisIntegrationTest.java later
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=A41AB26AFD3CCD90F48CA6CBD30C7B9B
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#L208-L229
Clone with 2 instances of length 17
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=C16CD5BDD1376AD975C24E682F0C2BB7
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#L195
TODO: update AbstractIrisIntegrationTest.java later
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=CA641CED5BED6FB6C6747C94BCEA5107
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#L217-L229
Clone with 3 instances of length 10
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=DC190E97C038C45122C8CA6CC9988505
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/iris/IrisCodeEditorMessageIntegrationTest.java#L17
Star import of `de.tum.in.www1.artemis.domain.iris.message.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=E13173EB6BD58C726DC1E3B47345F4D8
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/iris/IrisMessageIntegrationTest.java#L57-L82
Clone with 2 instances of length 16
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=5D598DD2F7589BDA30379B899C1C45F6
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/iris/IrisMessageIntegrationTest.java#L313-L334
Clone with 2 instances of length 17
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=749F0FAEFF9DEEBE1B799F80A1BBA6B1
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/iris/IrisMessageIntegrationTest.java#L145-L171
Clone with 2 instances of length 21
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=8A794584B9A805A38CFEBDAB41C19C12
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/iris/IrisMessageIntegrationTest.java#L21
Star import of `de.tum.in.www1.artemis.domain.iris.message.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=B86D8296B0F573EFA7DD74511835598C
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#L223-L268
This method is a bit lengthy [0] and deeply nested in multiple places [1, 2] which can make it hard to understand and maintain. Consider extracting helper methods or reducing the nesting by using early breaks or returns.
[0] https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=01387DA3D278C40A5489B4857576ABFE
[1] https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=A4A4052A0853E8C4E9BBC82DD4E9ECC4
[2] https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=70F834B6450BE8E720C16BF6FBBD70F0
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#L112-L148
This method is a bit lengthy [0]. Consider shortening it, e.g. by extracting code blocks into separate methods.
[0] https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=911EC0CFCCF7DE970EC023C914953ADD
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#L272
TODO: Implement
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=048F67FE518F2102CD245910B1ABB656
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#L61-L63
Interface comment missing
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=20FD75E0EE3839629C1FF7ABE745F8BF
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#L127
TODO: Consider refactoring this
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=2457B0379A1AF17E8029610D64431E2A
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#L273
Method 'extractChanges' returns null instead of empty collection
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=24CB32E26159689E7444A301422BB7C1
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#L61
Method `IrisCodeEditorSessionService` has 8 parameters but no more than 7 parameters are allowed
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=2AC35777C1DA97E087F4F915F6F3D2B2
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#L101
FIXME: Await update to Iris settings system
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=3480F41B6A539B10B0855E172C523182
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#L49
Private field `irisSettingsService` is never read
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=3D73731DB4D930295C8A7097987914CF
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisCodeEditorSessionService.java#L16
Star import of `de.tum.in.www1.artemis.domain.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Firis-code-editor-ui%3AHEAD&id=4A7C6EFE96D6FAA630B4739034070B1A
Loading