-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Remove testwise coverage support
#9993
Conversation
WIP: * server tests do not compile yet * client hestia code needs to be removed
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, there seems to be some occurrences of the testwise coverage report left:
- ProgrammingExerciseIntegrationJenkinsGitlabTest#createProgrammingExercise_testwiseCoverageAnalysisNotSupported_badRequest
- ProgrammingExerciseIntegrationTestService#createProgrammingExercise_testwiseCoverageAnalysisNotSupported_badRequest
- ProgrammingExerciseFactory#populateUnreleasedProgrammingExercise (unused method arg)
- ProgrammingExerciseUtilService (few occurrences for "testwise")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on TS3 and found no issues. All instructor actions—such as creating, editing, assessing, viewing scores, and modifying dates—worked as expected. I was able to participate as a student without any problems.
I found a few string occurrences in the code that might be related:
ProgrammingUtilTestService
: 'hestia' in a commentAeolusTemplateResource
:test coverage
in a commentfile.service.ts
: Multiple occurrences of 'coverage'codeHint.json
: This translation file seems to be unused_default-variables.scss
and_dark-variables.scss
: Styles related to monaco-editor-test-coverage-highlight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, added one personal suggestion
Checklist
General
Server
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Changes affecting Programming Exercises
Motivation and Context
This feature was not really used, but included lots of code that led to maintenance efforts
Description
This PR removes the features on the server and client side
Still missing: liquibase changes to remove the affected tables and columns in the database, will be added in a follow-up
Steps for Testing
Prerequisites:
Exam Mode Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Code Review
Manual Tests