Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated code lifecycle: Fix an issue with concurrent build queue access #9876

Merged

improve comments

9bae068
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Integrated code lifecycle: Fix an issue with concurrent build queue access #9876

improve comments
9bae068
Select commit
Loading
Failed to load commit list.
GitHub Actions / H2 Tests failed Nov 27, 2024 in 1s

8457 passed, 2 failed and 2 skipped

Tests failed
Report exceeded GitHub limit of 65535 bytes and has been trimmed

Annotations

Check failure on line 515 in src/test/java/de/tum/cit/aet/artemis/core/connector/GitlabRequestMockProvider.java

See this annotation in the file changed.

@github-actions github-actions / H2 Tests

de.tum.cit.aet.artemis.exam.StudentExamIntegrationTest ► testDeleteExamWithMultipleTestRuns()

Failed test found in:
  build/test-results/test/TEST-de.tum.cit.aet.artemis.exam.StudentExamIntegrationTest.xml
Error:
  org.mockito.exceptions.misusing.UnfinishedStubbingException: 
Raw output
org.mockito.exceptions.misusing.UnfinishedStubbingException: 
Unfinished stubbing detected here:
-> at de.tum.cit.aet.artemis.core.connector.GitlabRequestMockProvider.mockProtectBranch(GitlabRequestMockProvider.java:515)

E.g. thenReturn() may be missing.
Examples of correct stubbing:
    when(mock.isOk()).thenReturn(true);
    when(mock.isOk()).thenThrow(exception);
    doThrow(exception).when(mock).someVoidMethod();
Hints:
 1. missing thenReturn()
 2. you are trying to stub a final method, which is not supported
 3. you are stubbing the behaviour of another mock inside before 'thenReturn' instruction is completed

	at app//org.gitlab4j.api.ProtectedBranchesApi.protectBranch(ProtectedBranchesApi.java:141)
	at app//de.tum.cit.aet.artemis.core.connector.GitlabRequestMockProvider.mockProtectBranch(GitlabRequestMockProvider.java:515)
	at app//de.tum.cit.aet.artemis.core.connector.GitlabRequestMockProvider.mockConfigureRepository(GitlabRequestMockProvider.java:470)
	at app//de.tum.cit.aet.artemis.shared.base.AbstractSpringIntegrationJenkinsGitlabTest.mockConnectorRequestsForStartParticipation(AbstractSpringIntegrationJenkinsGitlabTest.java:241)
	at app//de.tum.cit.aet.artemis.exam.StudentExamIntegrationTest.testDeleteExamWithMultipleTestRuns(StudentExamIntegrationTest.java:396)
	at [email protected]/java.lang.reflect.Method.invoke(Method.java:580)
	at [email protected]/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at [email protected]/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
	at [email protected]/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
	at [email protected]/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
	at [email protected]/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)

Check failure on line 1483 in src/test/java/de/tum/cit/aet/artemis/programming/util/ProgrammingExerciseTestService.java

See this annotation in the file changed.

@github-actions github-actions / H2 Tests

de.tum.cit.aet.artemis.programming.ProgrammingExerciseGitlabJenkinsIntegrationTest ► resumeProgrammingExerciseByTriggeringInstructorBuild_correctInitializationState(ExerciseMode) [1] exerciseMode=INDIVIDUAL

Failed test found in:
  build/test-results/test/TEST-de.tum.cit.aet.artemis.programming.ProgrammingExerciseGitlabJenkinsIntegrationTest.xml
Error:
  org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in de.tum.cit.aet.artemis.programming.util.ProgrammingExerciseTestService was not fulfilled within 20 seconds.
Raw output
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in de.tum.cit.aet.artemis.programming.util.ProgrammingExerciseTestService was not fulfilled within 20 seconds.
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at app//de.tum.cit.aet.artemis.programming.util.ProgrammingExerciseTestService.resumeProgrammingExerciseByTriggeringInstructorBuild_correctInitializationState(ProgrammingExerciseTestService.java:1483)
	at app//de.tum.cit.aet.artemis.programming.ProgrammingExerciseGitlabJenkinsIntegrationTest.resumeProgrammingExerciseByTriggeringInstructorBuild_correctInitializationState(ProgrammingExerciseGitlabJenkinsIntegrationTest.java:358)
	at [email protected]/java.lang.reflect.Method.invoke(Method.java:580)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
	at [email protected]/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at [email protected]/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
	at [email protected]/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
	at [email protected]/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
	at [email protected]/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at [email protected]/java.util.Iterator.forEachRemaining(Iterator.java:133)
	at [email protected]/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1939)
	at [email protected]/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at [email protected]/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
	at [email protected]/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at [email protected]/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
	at [email protected]/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
	at [email protected]/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1708)
	at [email protected]/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at [email protected]/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
	at [email protected]/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at [email protected]/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
	at [email protected]/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
	at [email protected]/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at [email protected]/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at [email protected]/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at [email protected]/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1708)
	at [email protected]/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at [email protected]/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
	at [email protected]/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at [email protected]/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
	at [email protected]/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
	at [email protected]/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1708)
	at [email protected]/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at [email protected]/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
	at [email protected]/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at [email protected]/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
	at [email protected]/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at [email protected]/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
	at [email protected]/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
	at [email protected]/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
	at [email protected]/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)