Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lectures: Add spacing between categories and correct alignment #9860

Conversation

laxerhd
Copy link
Contributor

@laxerhd laxerhd commented Nov 25, 2024

Checklist

General

Client

Changes affecting Programming Exercises

  • High priority: I tested all changes and their related features with all corresponding user types on a test server configured with the integrated lifecycle setup (LocalVC and LocalCI).
  • I tested all changes and their related features with all corresponding user types on a test server configured with Gitlab and Jenkins.

Motivation and Context

The missing spaces between the categories/tags didn't look natural.
The offset also bothered me. Fixes #9857.

Description

I've added some space between the categories and fixed the misalignment of the them.

Steps for Testing

Prerequisites:

  • 1 Lecture with embedded programming exercise unit
  • Select some categories and difficulty for the exercise
  1. Log in to Artemis
  2. Navigate to Course -> Lecture
  3. Take a look at the categories

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Performance Tests

  • Test 1
  • Test 2

Test Coverage

Screenshots

Before:
image

After:
image

Summary by CodeRabbit

  • Style
    • Updated CSS styles for h4 elements to improve spacing and layout.

@laxerhd laxerhd requested a review from a team as a code owner November 25, 2024 18:33
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Nov 25, 2024
Copy link

coderabbitai bot commented Nov 25, 2024

Walkthrough

The changes involve updates to the CSS styles for the h4 element in the exercise-categories.component.scss file. The class selector has been changed from -h4 to .h4, and the margin properties have been adjusted: margin-bottom has been removed, margin-top has been set to 0.4rem, and margin-right has been increased to 0.4rem. These modifications impact the spacing around the h4 elements.

Changes

File Path Change Summary
src/main/webapp/app/shared/exercise-categories/exercise-categories.component.scss Changed class selector from -h4 to .h4, removed margin-bottom, set margin-top to 0.4rem, and increased margin-right to 0.4rem.

Possibly related PRs

Suggested labels

client, ready for review, small

Suggested reviewers

  • edkaya
  • rabeatwork
  • krusche
  • Malekos74

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between a4c674c and 150f5a8.

📒 Files selected for processing (1)
  • src/main/webapp/app/shared/exercise-categories/exercise-categories.component.scss (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/main/webapp/app/shared/exercise-categories/exercise-categories.component.scss

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Dec 4, 2024

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 4, 2024
@laxerhd
Copy link
Contributor Author

laxerhd commented Dec 7, 2024

Please unstale.

@laxerhd laxerhd force-pushed the bugfix/lectures/add-right-margin-to-category-and-fix-alignment branch from 150f5a8 to 76295f1 Compare December 7, 2024 00:17
@github-actions github-actions bot removed the stale label Dec 7, 2024
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 14, 2024
@laxerhd laxerhd force-pushed the bugfix/lectures/add-right-margin-to-category-and-fix-alignment branch from 76295f1 to c506761 Compare December 20, 2024 00:48
@laxerhd laxerhd requested a review from a team as a code owner December 20, 2024 00:48
@github-actions github-actions bot removed the stale label Dec 20, 2024
@laxerhd
Copy link
Contributor Author

laxerhd commented Dec 26, 2024

I am closing this PR because it originates from a branch in a forked repository, and our test server cannot be deployed on branches from forked repositories. I have already transferred the changes to a new branch in the main repository and will open a new PR from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!)
Projects
Status: Work In Progress
Development

Successfully merging this pull request may close these issues.

Lectures: Tags/categories have no empty space between them
1 participant