Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated code lifecycle: Improve consistency of titles in build overview #9801

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

MaximilianAnzinger
Copy link
Collaborator

@MaximilianAnzinger MaximilianAnzinger commented Nov 17, 2024

Checklist

General

Motivation and Context

Description

Fix titles of build job queue to be title case.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Course
  1. Log in to Artemis
  2. Navigate to Course Administration > Build Overview
  3. Check that the titles of the three tables are in title case (german & english translation)

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Code Review

  • no code, just translation :)

Manual Tests

  • Test 1
  • Test 2

Summary by CodeRabbit

  • Bug Fixes
    • Updated capitalization for localization strings to ensure consistency in the user interface.

@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Nov 17, 2024
@MaximilianAnzinger MaximilianAnzinger changed the title General: Improve UI consistency Integrated code lifecycle: Improve UI consistency Nov 17, 2024
@MaximilianAnzinger MaximilianAnzinger marked this pull request as ready for review November 17, 2024 09:36
@MaximilianAnzinger MaximilianAnzinger requested a review from a team as a code owner November 17, 2024 09:36
Copy link

coderabbitai bot commented Nov 17, 2024

Walkthrough

The changes in this pull request involve updates to the buildAgents.json localization file. Specifically, the casing of certain string values has been modified to ensure consistent capitalization. The strings "Running build jobs" and "Recent build jobs" have been changed to "Running Build Jobs" and "Recent Build Jobs," respectively.

Changes

File Path Change Summary
src/main/webapp/i18n/en/buildAgents.json Updated casing for "runningBuildJobs" and "recentBuildJobs" strings.

Possibly related PRs

Suggested labels

documentation, ready for review

Suggested reviewers

  • BBesrour
  • SimonEntholzer
  • krusche
  • EneaGore

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1786886 and 639225c.

📒 Files selected for processing (1)
  • src/main/webapp/i18n/en/buildAgents.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/main/webapp/i18n/en/buildAgents.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@HawKhiem HawKhiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS3. Works as expected

Screenshot 2024-11-17 134231
Screenshot 2024-11-17 134258

Copy link

⚠️ Unable to deploy to test servers ⚠️

Testserver "artemis-test1.artemis.cit.tum.de" is already in use by PR #9785.

@github-actions github-actions bot added the deployment-error Added by deployment workflows if an error occured label Nov 17, 2024
@ItsaaaMeMario ItsaaaMeMario removed the deployment-error Added by deployment workflows if an error occured label Nov 17, 2024
Copy link

@alekspetrov9e alekspetrov9e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS3. Works accordingly.

Copy link

@Cathy0123456789 Cathy0123456789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS3. Looks good

Copy link

⚠️ Unable to deploy to test servers ⚠️

Testserver "artemis-test3.artemis.cit.tum.de" is already in use by PR #9744.

@github-actions github-actions bot added the deployment-error Added by deployment workflows if an error occured label Nov 20, 2024
@krusche krusche changed the title Integrated code lifecycle: Improve UI consistency Integrated code lifecycle: Improve title consistency in build overview Nov 20, 2024
@krusche krusche changed the title Integrated code lifecycle: Improve title consistency in build overview Integrated code lifecycle: Improve consistency of titles in build overview Nov 20, 2024
@krusche krusche merged commit 59f5a04 into develop Nov 20, 2024
129 of 135 checks passed
@krusche krusche deleted the bugfix/fix-build-queue-headings branch November 20, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) deployment-error Added by deployment workflows if an error occured ready to merge
Projects
Archived in project
Status: Done
Development

Successfully merging this pull request may close these issues.

9 participants