Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Improve metrics integration test coverage #9306

Merged
merged 38 commits into from
Oct 11, 2024

Merge branch 'develop' into chore/learning-analytics/improve-metrics-…

61bd9e7
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Development: Improve metrics integration test coverage #9306

Merge branch 'develop' into chore/learning-analytics/improve-metrics-…
61bd9e7
Select commit
Loading
Failed to load commit list.
GitHub Actions / Junit Results failed Oct 8, 2024 in 0s

Junit Results

Junit Results ran 8167 in 1117.5899999999997 seconds 0 Errored, 3 Failed, 2 Skipped

Annotations

Check failure on line 0 in test

See this annotation in the file changed.

@github-actions github-actions / Junit Results

test#L0 

Junit Results ran 8167 in 1117.5899999999997 seconds 0 Errored, 3 Failed, 2 Skipped

Check failure on line 0 in /home/runner/work/Artemis/Artemis/src/test/java/de/tum/cit/aet/artemis/assessment/ResultListenerIntegrationTest.java

See this annotation in the file changed.

@github-actions github-actions / Junit Results

updateExercisePoints_ShouldUpdatePointsInParticipantScores(boolean) [2] isTeamTest=false 

Junit test updateExercisePoints_ShouldUpdatePointsInParticipantScores(boolean) [2] isTeamTest=false failed org.opentest4j.AssertionFailedError: 
expected: 200.0
 but was: 20.0
Raw output 
org.opentest4j.AssertionFailedError: 
expected: 200.0
 but was: 20.0
	at app//de.tum.cit.aet.artemis.assessment.ResultListenerIntegrationTest.updateExercisePoints_ShouldUpdatePointsInParticipantScores(ResultListenerIntegrationTest.java:128)
	at [email protected]/java.lang.reflect.Method.invoke(Method.java:580)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
	at [email protected]/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at [email protected]/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
	at [email protected]/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
	at [email protected]/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
	at [email protected]/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at [email protected]/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:1024)
	at [email protected]/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at [email protected]/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
	at [email protected]/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at [email protected]/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
	at [email protected]/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
	at [email protected]/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1708)
	at [email protected]/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at [email protected]/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
	at [email protected]/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at [email protected]/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
	at [email protected]/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
	at [email protected]/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at [email protected]/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at [email protected]/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at [email protected]/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1708)
	at [email protected]/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at [email protected]/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
	at [email protected]/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at [email protected]/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
	at [email protected]/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
	at [email protected]/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1708)
	at [email protected]/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at [email protected]/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
	at [email protected]/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
	at [email protected]/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at [email protected]/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
	at [email protected]/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
	at [email protected]/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at [email protected]/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
	at [email protected]/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
	at [email protected]/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
	at [email protected]/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)

Check failure on line 544 in /home/runner/work/Artemis/Artemis/src/test/java/de/tum/cit/aet/artemis/communication/notification/SingleUserNotificationServiceTest.java

See this annotation in the file changed.

@github-actions github-actions / Junit Results

testTutorialGroupNotifications_groupUnassigned() 

Junit test testTutorialGroupNotifications_groupUnassigned() failed org.mockito.exceptions.verification.TooManyActualInvocations: 
applePushNotificationService.sendNotification(
    <any de.tum.cit.aet.artemis.communication.domain.notification.Notification>,
    <any set>,
    <any java.lang.Object>
);
Wanted 1 time:
-> at de.tum.cit.aet.artemis.communication.service.notifications.push_notifications.PushNotificationService.sendNotification(PushNotificationService.java:144)
But was 2 times:
-> at de.tum.cit.aet.artemis.communication.service.notifications.push_notifications.PushNotificationService.sendNotification(PushNotificationService.java:129)
-> at de.tum.cit.aet.artemis.communication.service.notifications.push_notifications.PushNotificationService.sendNotification(PushNotificationService.java:129)
Raw output 
org.mockito.exceptions.verification.TooManyActualInvocations: 
applePushNotificationService.sendNotification(
    <any de.tum.cit.aet.artemis.communication.domain.notification.Notification>,
    <any set>,
    <any java.lang.Object>
);
Wanted 1 time:
-> at de.tum.cit.aet.artemis.communication.service.notifications.push_notifications.PushNotificationService.sendNotification(PushNotificationService.java:144)
But was 2 times:
-> at de.tum.cit.aet.artemis.communication.service.notifications.push_notifications.PushNotificationService.sendNotification(PushNotificationService.java:129)
-> at de.tum.cit.aet.artemis.communication.service.notifications.push_notifications.PushNotificationService.sendNotification(PushNotificationService.java:129)


	at app//de.tum.cit.aet.artemis.communication.service.notifications.push_notifications.PushNotificationService.sendNotification(PushNotificationService.java:144)
	at app//de.tum.cit.aet.artemis.communication.notification.SingleUserNotificationServiceTest.verifyPush(SingleUserNotificationServiceTest.java:583)
	at app//de.tum.cit.aet.artemis.communication.notification.SingleUserNotificationServiceTest.testTutorialGroupNotifications_groupUnassigned(SingleUserNotificationServiceTest.java:551)
	at [email protected]/java.lang.reflect.Method.invoke(Method.java:580)
	at [email protected]/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
	at [email protected]/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at [email protected]/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
	at [email protected]/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
	at [email protected]/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
	at [email protected]/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)

Check failure on line 409 in /home/runner/work/Artemis/Artemis/src/test/java/de/tum/cit/aet/artemis/modeling/ModelingExerciseIntegrationTest.java

See this annotation in the file changed.

@github-actions github-actions / Junit Results

testDeleteModelingExerciseWithCompetency() 

Junit test testDeleteModelingExerciseWithCompetency() failed Wanted but not invoked:
competencyProgressService.updateProgressByCompetencyAsync(
    de.tum.cit.aet.artemis.atlas.domain.competency.Competency@34
);
-> at de.tum.cit.aet.artemis.atlas.service.competency.CompetencyProgressService.updateProgressByCompetencyAsync(CompetencyProgressService.java:123)
Actually, there were zero interactions with this mock.
Raw output 
Wanted but not invoked:
competencyProgressService.updateProgressByCompetencyAsync(
    de.tum.cit.aet.artemis.atlas.domain.competency.Competency@34
);
-> at de.tum.cit.aet.artemis.atlas.service.competency.CompetencyProgressService.updateProgressByCompetencyAsync(CompetencyProgressService.java:123)
Actually, there were zero interactions with this mock.

	at app//de.tum.cit.aet.artemis.atlas.service.competency.CompetencyProgressService.updateProgressByCompetencyAsync(CompetencyProgressService.java:123)
	at app//de.tum.cit.aet.artemis.modeling.ModelingExerciseIntegrationTest.testDeleteModelingExerciseWithCompetency(ModelingExerciseIntegrationTest.java:415)
	at [email protected]/java.lang.reflect.Method.invoke(Method.java:580)
	at [email protected]/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
	at [email protected]/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at [email protected]/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
	at [email protected]/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
	at [email protected]/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
	at [email protected]/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)
View more details on GitHub Actions