Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication: Fix tooltip translation for the tutor icon in the conversation member list #9229

Conversation

konrad2002
Copy link
Member

@konrad2002 konrad2002 commented Aug 18, 2024

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I strictly followed the client coding and design guidelines.

Motivation and Context

Fixes #9194

Description

  • the translation used the wrong key (artemisApp.metis.userAuthorityTooltips.ta instead of artemisApp.metis.userAuthorityTooltips.tutor)
  • this affected the icon tooltip for both tutors and editors

Steps for Testing

Prerequisites:

  • Course with "communication" feature enabled
  • Channel with at least one Tutor and one Editor
  1. Log in to Artemis
  2. Navigate to the communication page of the course
  3. Click on the channel
  4. Click on the button with the user icon and the amount of member
  5. In the members list, search for a tutor account and a editor account
  6. Verify that the icon in front of the name shows a correctly translated tooltip
  7. Verify it for both English and German language

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Screenshots

image image

Tooltip now showing the right text in both English and German

Summary by CodeRabbit

  • New Features
    • Updated tooltip text for teaching assistants from "ta" to "tutor" to improve clarity and align with updated terminology.

These changes enhance user understanding of conversation member roles within the interface.

@konrad2002 konrad2002 self-assigned this Aug 18, 2024
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Aug 18, 2024
@konrad2002 konrad2002 temporarily deployed to artemis-test2.artemis.cit.tum.de August 18, 2024 09:34 — with GitHub Actions Inactive
@konrad2002 konrad2002 marked this pull request as ready for review August 18, 2024 09:45
@konrad2002 konrad2002 requested a review from a team as a code owner August 18, 2024 09:45
Copy link

coderabbitai bot commented Aug 18, 2024

Walkthrough

The recent update to the ConversationMemberRowComponent involved changing the tooltip text for teaching assistants from "ta" to "tutor." This adjustment aims to enhance clarity and align with updated terminology regarding the roles of conversation members, particularly in the context of communication channels.

Changes

File Change Summary
src/main/webapp/app/overview/course-conversations/dialogs/conversation-detail-dialog/... Updated tooltip text for teaching assistants from 'ta' to 'tutor' to improve clarity.

Assessment against linked issues

Objective Addressed Explanation
Missing or wrong translation for tutor icon tooltip in channel member overview (#9194)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Copy link
Contributor

@SimonEntholzer SimonEntholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on Ts2 👍

Copy link
Contributor

@dmytropolityka dmytropolityka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code & tested on ts2

Copy link
Contributor

@Jan-Thurner Jan-Thurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS2. Code LGTM.

@maximiliansoelch maximiliansoelch added ready to merge maintainer-approved The feature maintainer has approved the PR and removed ready for review labels Aug 19, 2024
@maximiliansoelch maximiliansoelch added this to the 7.5.1 milestone Aug 19, 2024
@krusche krusche merged commit cf250f1 into develop Aug 21, 2024
64 of 68 checks passed
@krusche krusche deleted the bugfix/communication/conversation-member-tooltip-translation-tutor branch August 21, 2024 10:19
JohannesWt pushed a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix client Pull requests that update TypeScript code. (Added Automatically!) component:Communication maintainer-approved The feature maintainer has approved the PR ready to merge small
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Communication: Missing or wrong translation for tutor icon tooltip in channel member overview
8 participants