-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Communication
: Combine messages and communication view
#8801
Merged
krusche
merged 97 commits into
develop
from
chore/communication/merge-messages-and-communication
Jun 30, 2024
Merged
Communication
: Combine messages and communication view
#8801
krusche
merged 97 commits into
develop
from
chore/communication/merge-messages-and-communication
Jun 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/webapp/app/overview/course-overview.service.ts
anian03
approved these changes
Jun 28, 2024
egekurt123
temporarily deployed
to
artemis-test3.artemis.cit.tum.de
June 29, 2024 16:23 — with
GitHub Actions
Inactive
krusche
changed the title
Jun 30, 2024
Communication
: Merge Messages and Communication ModulesCommunication
: Combine messages and communication view
This was referenced Sep 22, 2024
This was referenced Oct 11, 2024
This was referenced Oct 23, 2024
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
client
Pull requests that update TypeScript code. (Added Automatically!)
component:Communication
cypress
Pull requests that update cypress tests. (Added Automatically!)
database
Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment.
documentation
ready for review
server
Pull requests that update Java code. (Added Automatically!)
tests
user interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
Solves #8585
This PR removes the legacy Communication module and makes the direct messages and group chats in the Messages module optional. With this update, users and instructors can access the same communication functions within the Messages module. The configuration is like before on create/edit course page.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests
Screenshots
Enabling Direct Messages / Group Chats in Course Management Page:
Communication Sidebar when enabling Direct Messages / Group Chats
Communication Sidebar when disabling Direct Messages / Group Chats
General Sidebar and Overview
Course Management Header
Course Management View
Test Coverage
Client
Server
�
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Style
Documentation
Tests