Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Upgrade to Angular 18 #8687

Merged
merged 61 commits into from
Jun 20, 2024
Merged

Development: Upgrade to Angular 18 #8687

merged 61 commits into from
Jun 20, 2024

Conversation

JohannesWt
Copy link
Contributor

@JohannesWt JohannesWt commented May 28, 2024

Checklist

General

Client

Motivation and Context

This PR fixes issues preventing the upgrade to Angular 18

Due to the version changes the following things mainly have been changed:

  • add a tracking id to @for loops in Angular
  • upgrade loadings spinners to new syntax of FontAwesome
  • fix tests due to deprecation

Description

In this PR several issues have been resolved which prevented the upgrade to Angular 18. Using [styles] in a component is not supported anymore. Therefore the affected places have been mainly restructured using bootstrap classes and some custom (but simplified) css. Additionally the [spin] attribute of fa-icons is not supported anymore which also has been replaced by its new alternative.
Also quite a lot of tests had to be refactored due to changes/deprecation of Angular or some other npm packages

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked






Review Progress

Code Review

  • Code Review 1
  • Code Review 2

@JohannesWt JohannesWt self-assigned this May 28, 2024
@github-actions github-actions bot added tests client Pull requests that update TypeScript code. (Added Automatically!) labels May 28, 2024
@krusche krusche self-assigned this Jun 1, 2024
@JohannesWt JohannesWt temporarily deployed to artemis-test4.artemis.cit.tum.de June 19, 2024 12:24 — with GitHub Actions Inactive
JohannesStoehr
JohannesStoehr previously approved these changes Jun 19, 2024
Copy link
Contributor

@JohannesStoehr JohannesStoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Testing session. Did not find any problems

az108
az108 previously approved these changes Jun 19, 2024
Copy link
Contributor

@az108 az108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Testing Session, no errors were found

EneaGore
EneaGore previously approved these changes Jun 19, 2024
Copy link
Contributor

@EneaGore EneaGore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS4. Did not encounter any issues.

BBesrour
BBesrour previously approved these changes Jun 19, 2024
Copy link
Member

@BBesrour BBesrour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demonstrated and tested in a testing session

dmytropolityka
dmytropolityka previously approved these changes Jun 19, 2024
Copy link
Contributor

@dmytropolityka dmytropolityka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't find any issues while testing in a testing session

coolchock
coolchock previously approved these changes Jun 19, 2024
Copy link
Contributor

@coolchock coolchock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in testing session, no weird behaviour observed

@krusche krusche added this to the 7.2.3 milestone Jun 19, 2024
krusche
krusche previously approved these changes Jun 19, 2024
pzdr7
pzdr7 previously approved these changes Jun 19, 2024
Copy link
Contributor

@pzdr7 pzdr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

marlon-luca-bu
marlon-luca-bu previously approved these changes Jun 20, 2024
Copy link
Contributor

@marlon-luca-bu marlon-luca-bu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

sarpsahinalp
sarpsahinalp previously approved these changes Jun 20, 2024
Copy link
Contributor

@sarpsahinalp sarpsahinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

@krusche krusche merged commit c63709d into develop Jun 20, 2024
12 of 15 checks passed
@krusche krusche deleted the chore/angular18 branch June 20, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) documentation ready for review tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.