-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Fix issue where the VCS token is not present for some users after logging in
#8247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
client
Pull requests that update TypeScript code. (Added Automatically!)
labels
Mar 24, 2024
Strohgelaender
approved these changes
Mar 30, 2024
chrisknedl
temporarily deployed
to
artemis-test1.artemis.cit.tum.de
April 3, 2024 09:04 — with
GitHub Actions
Inactive
BaumiCoder
approved these changes
Apr 10, 2024
b-fein
approved these changes
Apr 12, 2024
rabeatwork
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
client
Pull requests that update TypeScript code. (Added Automatically!)
ready to merge
small
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@coderabbitai ignore
Checklist
General
Client
Motivation and Context
This issue was initially discovered when a user participates in an exercise for the first time after being created, in which case the VCS access token might be missing, and therefore the resulting repo URL is not correct and cannot be used to clone the repository. This PR fixes this problem and other related issues that might possibly still be undiscovered.
Description
To fix this issue, the user caching mechanism not only checks if the user object is initialized, but also if it contains the token when one is expected. If not, the user is fetched from the database.
Steps for Testing
This issue can only be reproduced with old accounts that were present before the
vcsAccessToken
feature was activated. Because of this, the PR also doesn't change anything for the test servers.What you can check:
On any test server check that the clone URL is still shown when participating as student in a programming exercise. Ideally one test for a testserver connected to GitLab/Jenkins and another one to either Bamboo or LocalVCS.
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage