Development: Clean up .github/workflows/docs.yml variables
#7477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lucas Welscher <[email protected]>
|
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
|
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
bensofficial
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Motivation and Context
This PR is related to Development: Migrate documentation to docs.artemis.cit.tum.de #7298, and re-organizes the documentation deployment workflow in order to keep a clean state of GitHub repository secrets.
Description
Secrets of
.github/workflows/docs.ymlwere converted to (environment) variables, in order to have a cleaner state of the repository secrets. Once this PR is merged, the unused secrets have to be removed.Permissions set for the
.github/workflows/docs.ymlworkflow were also cleaned up, as they were only relevant to the (now stale) GitHub Pages deployment.Triggers set for the
.github/workflows/docs.ymlworkflow were modified so that the documentation is not redeployed using the code of new PRs.Steps for Testing
The workflow has been tested on a separate repository using an identical environment. This PR does not modify the functionality of Artemis.