Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Fix display of user group and categories selection #7441

Merged

Conversation

florian-glombik
Copy link
Contributor

@florian-glombik florian-glombik commented Oct 24, 2023

Checklist

General

Client

  • I followed the coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Description

Steps for Testing

Prerequisites:

  • 1 Administrator
  • 1 Student
  • 1 Course with user groups
  1. Administrator: Navigate to Server Administration > User management > Edit
  2. Adjust the user groups
  3. Verify that the selection is easy to read and the background is not transparent

You can also verify it by checking the badges of exercises

  1. Edit an existing exercise
  2. Add categories
  3. See that the background is not transparent

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1

Screenshots

Before (transparent, hard to read) After (not transparent, easy to read)
broken light mode fixed light mode
broken dark mode fixed dark mode

Fixed aswell at other places, e.g. for the categories selection of exercises
image

@florian-glombik florian-glombik added client Pull requests that update TypeScript code. (Added Automatically!) small bugfix dark mode labels Oct 24, 2023
@florian-glombik florian-glombik self-assigned this Oct 24, 2023
@florian-glombik florian-glombik changed the title Adding CSS that resolves the problem General: Fix display of user group selection Oct 24, 2023
@florian-glombik florian-glombik marked this pull request as ready for review October 24, 2023 21:00
@florian-glombik florian-glombik requested a review from a team as a code owner October 24, 2023 21:00
@florian-glombik florian-glombik added this to the 6.6.3 milestone Oct 24, 2023
@xHadie
Copy link

xHadie commented Oct 25, 2023

Tested on TS2_Legacy

Your changes look good! The transparency is gone.

@florian-glombik florian-glombik temporarily deployed to artemis-test2.artemis.cit.tum.de October 25, 2023 12:49 — with GitHub Actions Inactive
Copy link
Contributor

@simon-hng simon-hng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. Perfect CSS!

Copy link
Contributor

@jakubriegel jakubriegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@florian-glombik florian-glombik temporarily deployed to artemis-test2.artemis.cit.tum.de October 25, 2023 20:37 — with GitHub Actions Inactive
@florian-glombik florian-glombik changed the title General: Fix display of user group selection General: Fix display of user group and categories selection Oct 25, 2023
@krusche krusche merged commit a535084 into develop Oct 26, 2023
103 of 108 checks passed
@krusche krusche deleted the bugfix/user-management/fix-display-of-user-group-selection branch October 26, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix client Pull requests that update TypeScript code. (Added Automatically!) ready to merge small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants