-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General
: Fix display of user group and categories selection
#7441
Merged
krusche
merged 1 commit into
develop
from
bugfix/user-management/fix-display-of-user-group-selection
Oct 26, 2023
Merged
General
: Fix display of user group and categories selection
#7441
krusche
merged 1 commit into
develop
from
bugfix/user-management/fix-display-of-user-group-selection
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-glombik
added
client
Pull requests that update TypeScript code. (Added Automatically!)
small
bugfix
dark mode
labels
Oct 24, 2023
florian-glombik
changed the title
Adding CSS that resolves the problem
Oct 24, 2023
General
: Fix display of user group selection
Tested on TS2_Legacy Your changes look good! The transparency is gone. |
florian-glombik
temporarily deployed
to
artemis-test2.artemis.cit.tum.de
October 25, 2023 12:49 — with
GitHub Actions
Inactive
simon-hng
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM. Perfect CSS!
jakubriegel
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
florian-glombik
added
ready to merge
deploy:artemis-test2
and removed
lock:artemis-test2
ready for review
labels
Oct 25, 2023
florian-glombik
temporarily deployed
to
artemis-test2.artemis.cit.tum.de
October 25, 2023 20:37 — with
GitHub Actions
Inactive
florian-glombik
changed the title
Oct 25, 2023
General
: Fix display of user group selectionGeneral
: Fix display of user group and categories selection
krusche
deleted the
bugfix/user-management/fix-display-of-user-group-selection
branch
October 26, 2023 09:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
client
Pull requests that update TypeScript code. (Added Automatically!)
ready to merge
small
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Client
Motivation and Context
Description
Steps for Testing
Prerequisites:
Administrator
: Navigate toServer Administration
>User management
>Edit
You can also verify it by checking the badges of exercises
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Code Review
Manual Tests
Screenshots
Fixed aswell at other places, e.g. for the categories selection of exercises