Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development: Add JavaDocs to UtilServices and Factories [11] #7427

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Development: Add JavaDocs to UtilServices and Factories [11] #7427

merged 4 commits into from
Nov 2, 2023

Conversation

DominikRemo
Copy link
Contributor

@DominikRemo DominikRemo commented Oct 20, 2023 •
edited by MaximilianAnzinger
Loading

Checklist

General

Motivation and Context

Improve the readability of UtilServices and Factories by adding JavaDoc to the helper methods

Description

Added documentation to following files:

  • organization/OrganizationFactory.java
  • organization/OrganizationUtilService.java
    --
  • participation/ParticipationFactory.java
  • participation/ParticipationUtilService.java

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

@DominikRemo DominikRemo mentioned this pull request Oct 20, 2023
Merged
42 tasks
@github-actions github-actions bot added the tests label Oct 20, 2023
@github-actions

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot added the stale label Oct 28, 2023
@laadvo laadvo removed the stale label Oct 29, 2023
@DominikRemo DominikRemo requested a review from laadvo October 29, 2023 17:44
@DominikRemo DominikRemo marked this pull request as ready for review October 29, 2023 17:44
@DominikRemo DominikRemo requested a review from a team as a code owner October 29, 2023 17:44
reschandreas
reschandreas approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@reschandreas reschandreas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for adding more documentational comments 👍🏻

@DominikRemo DominikRemo merged commit 2d9bfdd into development/add-javadoc-to-utilservices-and-factories/main Nov 2, 2023
20 of 22 checks passed
@DominikRemo DominikRemo deleted the development/add-javadoc-to-utilservices-and-factories/add-javadoc-group-11 branch November 2, 2023 14:00
@DominikRemo DominikRemo removed the request for review from laadvo November 2, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximilianAnzinger MaximilianAnzinger MaximilianAnzinger approved these changes

@reschandreas reschandreas reschandreas approved these changes

Assignees

@DominikRemo DominikRemo

Labels
ready to merge tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DominikRemo @reschandreas @MaximilianAnzinger @laadvo