-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iris
: Rework settings system
#7424
Conversation
# Conflicts: # src/main/java/de/tum/in/www1/artemis/repository/iris/IrisSettingsRepository.java # src/main/java/de/tum/in/www1/artemis/service/iris/IrisSettingsService.java
…nto refactor/iris-settings-rework
# Conflicts: # src/main/webapp/app/course/manage/course-management-tab-bar/course-management-tab-bar.component.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm in general, leave some comments
src/main/java/de/tum/in/www1/artemis/service/iris/settings/IrisSubSettingsService.java
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/iris/settings/IrisSubSettingsService.java
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/iris/settings/IrisSubSettingsService.java
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/iris/settings/IrisSubSettingsService.java
Show resolved
Hide resolved
...ttings-update/iris-common-sub-settings-update/iris-common-sub-settings-update.component.html
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM and worked well!
…d exercise detail pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in our Code Editor Chatbot PR, works well.
Only deploy to TS9
Checklist
General
Server
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
The Iris Settings are currently in a very early state and are not very well implemented and scalable to new features. This PR aims to remedy that.
Description
Completely reworked the server side of the Iris Settings:
Smaller adjustments to the UI:
Steps for Testing
Prerequisites:
TS9 Status
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Client
Server
Screenshots
Global Settings:
Course Settings (now as a proper sub-page)
Moved Iris Button on PE page:
Programming Exercise Settings:
Enable/Disable on the exercise/course detail pages: