`General`: Do not show certain buttons for tutors in lecture overview and course management #7423

JohannesStoehr · 2023-10-19T15:06:49Z

Checklist

General

This is a small issue that I tested locally and was confirmed by another developer on a test server.
I chose a title conforming to the naming conventions for pull requests.

Client

Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
I followed the coding and design guidelines.
I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Fixes #7422 and also some other occurrences I noticed when fixing this issue.

Description

Fixes authorities and hides the following buttons from tutors:

Manage button in the lecture view inside a course (the one from Lecture: lecture unit creation page visible even if no permission #7422)
"Edit"/"Attachment"/"Units" buttons in the manage page of a lecture
Scores button in the course management tab bar
In the general course management the "Tutorials" button in the course card, if there is no tutorial configuration yet

Also shows the tutorials button in the course management tab bar of a specific course so tutors have access to their tutor groups and can sign up students. This is only possible after an instructor has configured the tutorial groups.

Steps for Testing

Prerequisites:

1 Tutor
1 Editor/Instruktor

Check that the buttons are successfully hidden from tutors in a course without a tutorial group configuration
Check that instructors see all buttons
Enable tutorial groups (the tutorials tab guides the instructor through this) or find a course with tutorial groups enabled
Check that tutors can now access tutorials in the course management
(Also see attached screenshots and links to examples on TS1)

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Performance Review

I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance

Code Review

Code Review 1
Code Review 2

Manual Tests

Test 1
Test 2

Screenshots

The hidden Buttons:

Manage button, e.g. here: https://artemis-test1.artemis.in.tum.de/courses/118/lectures/215

"Edit"/"Attachment"/"Units" buttons, e.g. here: https://artemis-test1.artemis.in.tum.de/course-management/118/lectures/215

Scores button and tutorials button not visible to tutors, e.g. here: https://artemis-test1.artemis.in.tum.de/course-management/118

Tutorials button visible in tab bar, e.g. here: https://artemis-test1.artemis.in.tum.de/course-management/118

Tutorials button visible in course management card, e.g. here: https://artemis-test1.artemis.in.tum.de/course-management under the test course section

konrad2002

LGTM
Tested on Legacy TS2

Strohgelaender

code lgtm, thanks for adding a small additional client test

…ge-authorities

MaximilianAnzinger

Code lgtm

dearjasmina

tested on ts1, works as described for both tutor and instructor roles 👍🏻

…urse-manage-authorities' into bugfix/fix-manage-lecture-and-course-manage-authorities

JanaNF

Tested on ts1. All good

konrad2002

tested it on legacy ts11

I'm not sure if it is supposed to be like this, but as a tutor I wasn't able to open the tutorial groups page..

As instructor this worked

Tutor:

When clicking, nothing happens (+ no error in console)

Instructor:

After clicking on tutorials

JohannesStoehr · 2023-10-21T09:32:16Z

src/main/webapp/app/course/manage/overview/course-management-card.component.html

@@ -254,7 +254,7 @@ <h4 class="text-center no-exercises mt-3 fw-medium">{{ 'artemisApp.course.noExer
            <span class="d-none d-xl-inline">{{ 'artemisApp.courseOverview.menu.messages' | artemisTranslate }}</span>
        </a>
        <a
-            *ngIf="course.isAtLeastTutor"
+            *ngIf="course.timeZone || course.isAtLeastInstructor"


We currently don't load the tutorialGroupsConfiguration here and to keep this PR small I decided to only use the timeZone here, which is also a prerequisite for tutorials

MaximilianAnzinger

Code

JanaNF

Manual tested on legacy ts2. Worked as expected... again ;)

sarpsahinalp

Tested on ts3 works as expected.
Tutor side:

Instructor side:

Fix more button authorities

3f30d2e

JohannesStoehr added ready for review client Pull requests that update TypeScript code. (Added Automatically!) small bugfix user interface labels Oct 19, 2023

JohannesStoehr added this to the 6.6.2 milestone Oct 19, 2023

JohannesStoehr self-assigned this Oct 19, 2023

JohannesStoehr requested a review from a team as a code owner October 19, 2023 15:06

github-actions bot added the tests label Oct 19, 2023

JohannesStoehr requested review from Strohgelaender, JanaNF and MaximilianAnzinger October 19, 2023 15:29

konrad2002 previously approved these changes Oct 19, 2023

View reviewed changes

Strohgelaender previously approved these changes Oct 19, 2023

View reviewed changes

Merge branch 'develop' into bugfix/fix-manage-lecture-and-course-mana…

9650fb6

…ge-authorities

MaximilianAnzinger previously approved these changes Oct 20, 2023

View reviewed changes

dearjasmina previously approved these changes Oct 20, 2023

View reviewed changes

JohannesStoehr added ready to merge and removed ready for review labels Oct 20, 2023

JohannesStoehr added 2 commits October 20, 2023 20:04

Also show tutors the tutorial section

2b7cc73

Merge remote-tracking branch 'origin/bugfix/fix-manage-lecture-and-co…

0d193b1

…urse-manage-authorities' into bugfix/fix-manage-lecture-and-course-manage-authorities

JohannesStoehr dismissed stale reviews from dearjasmina, MaximilianAnzinger, konrad2002, and Strohgelaender via 0d193b1 October 20, 2023 18:05

JohannesStoehr added ready for review and removed ready to merge labels Oct 20, 2023

JohannesStoehr requested review from dearjasmina, Strohgelaender, MaximilianAnzinger and konrad2002 October 20, 2023 19:03

JanaNF previously approved these changes Oct 20, 2023

View reviewed changes

konrad2002 requested changes Oct 20, 2023

View reviewed changes

Fix tutorial groups button

fc1bd2a

JohannesStoehr dismissed JanaNF’s stale review via fc1bd2a October 21, 2023 09:03

JohannesStoehr commented Oct 21, 2023

View reviewed changes

JohannesStoehr requested review from konrad2002 and JanaNF October 21, 2023 09:36

JohannesStoehr changed the title ~~General: Hide unavailable buttons from tutors in lecture overview and course management~~ General: Fix button authorities for tutors in lecture overview and course management Oct 21, 2023

konrad2002 approved these changes Oct 21, 2023

View reviewed changes

krusche modified the milestones: 6.6.2, 6.6.3 Oct 21, 2023

MaximilianAnzinger approved these changes Oct 22, 2023

View reviewed changes

JanaNF approved these changes Oct 23, 2023

View reviewed changes

Strohgelaender approved these changes Oct 24, 2023

View reviewed changes

JohannesStoehr added ready to merge and removed ready for review labels Oct 24, 2023

sarpsahinalp approved these changes Oct 24, 2023

View reviewed changes

krusche changed the title ~~General: Fix button authorities for tutors in lecture overview and course management~~ General: Do not show certain buttons for tutors in lecture overview and course management Oct 26, 2023

krusche merged commit 2f5d20c into develop Oct 26, 2023
37 of 40 checks passed

krusche deleted the bugfix/fix-manage-lecture-and-course-manage-authorities branch October 26, 2023 09:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`General`: Do not show certain buttons for tutors in lecture overview and course management #7423

`General`: Do not show certain buttons for tutors in lecture overview and course management #7423

JohannesStoehr commented Oct 19, 2023 •

edited

Loading

konrad2002 left a comment •

edited

Loading

Strohgelaender left a comment

MaximilianAnzinger left a comment

dearjasmina left a comment

JanaNF left a comment

konrad2002 left a comment

JohannesStoehr Oct 21, 2023

MaximilianAnzinger left a comment

JanaNF left a comment

sarpsahinalp left a comment

General: Do not show certain buttons for tutors in lecture overview and course management #7423

General: Do not show certain buttons for tutors in lecture overview and course management #7423

Conversation

JohannesStoehr commented Oct 19, 2023 • edited Loading

Checklist

General

Client

Motivation and Context

Description

Steps for Testing

Testserver States

Review Progress

Performance Review

Code Review

Manual Tests

Screenshots

konrad2002 left a comment • edited Loading

Choose a reason for hiding this comment

Strohgelaender left a comment

Choose a reason for hiding this comment

MaximilianAnzinger left a comment

Choose a reason for hiding this comment

dearjasmina left a comment

Choose a reason for hiding this comment

JanaNF left a comment

Choose a reason for hiding this comment

konrad2002 left a comment

Choose a reason for hiding this comment

Tutor:

Instructor:

JohannesStoehr Oct 21, 2023

Choose a reason for hiding this comment

MaximilianAnzinger left a comment

Choose a reason for hiding this comment

JanaNF left a comment

Choose a reason for hiding this comment

sarpsahinalp left a comment

Choose a reason for hiding this comment

`General`: Do not show certain buttons for tutors in lecture overview and course management #7423

`General`: Do not show certain buttons for tutors in lecture overview and course management #7423

JohannesStoehr commented Oct 19, 2023 •

edited

Loading

konrad2002 left a comment •

edited

Loading