Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Only run badge update job if the label is a lock label #7421

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

Hialus
Copy link
Member

@Hialus Hialus commented Oct 19, 2023

Checklist

General

Motivation and Context

The new workflow for when a lock label is removed is currently always running, even for non-lock labels. This takes an unecessary amount of time.

Description

This PR fixes this by adding an if statement to the job. This reduces the run time by >10x.

Steps for Testing

N/A

Review Progress

Code Review

  • Code Review 1

@Hialus Hialus self-assigned this Oct 19, 2023
@Hialus Hialus marked this pull request as ready for review October 20, 2023 00:38
@Hialus Hialus requested a review from a team as a code owner October 20, 2023 00:38
@Hialus Hialus requested a review from Mtze October 20, 2023 00:38
@krusche krusche added this to the 6.6.2 milestone Oct 21, 2023
@krusche krusche merged commit ac334ac into develop Oct 21, 2023
@krusche krusche deleted the bugfix/lock-unlabeled-workflow-fix branch October 21, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants