Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development: Add JavaDocs to UtilServices and Factories [10] #7420

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Development: Add JavaDocs to UtilServices and Factories [10] #7420

merged 3 commits into from
Oct 20, 2023

Conversation

DominikRemo
Copy link
Contributor

@DominikRemo DominikRemo commented Oct 19, 2023 •
edited
Loading

Checklist

General

Motivation and Context

Improve the readability of UtilServices and Factories by adding JavaDoc to the helper methods

Description

Added documentation to following files:

  • lecture/LectureFactory.java
  • lecture/LectureUtilService.java

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

@DominikRemo DominikRemo mentioned this pull request Oct 19, 2023
Merged
42 tasks
@github-actions github-actions bot added the tests label Oct 19, 2023
@DominikRemo DominikRemo marked this pull request as ready for review October 19, 2023 08:27
@DominikRemo DominikRemo requested a review from a team as a code owner October 19, 2023 08:27
chrisknedl
chrisknedl approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@chrisknedl chrisknedl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@DominikRemo DominikRemo requested a review from laadvo October 19, 2023 17:22
valentin-boehm
valentin-boehm approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@valentin-boehm valentin-boehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

MaximilianAnzinger
MaximilianAnzinger approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@MaximilianAnzinger MaximilianAnzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DominikRemo
Merge branch 'development/add-javadoc-to-utilservices-and-factories/m…
13e3a2a 
…ain' into development/add-javadoc-to-utilservices-and-factories/add-javadoc-group-10
@DominikRemo DominikRemo merged commit 5a47e3c into development/add-javadoc-to-utilservices-and-factories/main Oct 20, 2023
15 of 16 checks passed
@DominikRemo DominikRemo deleted the development/add-javadoc-to-utilservices-and-factories/add-javadoc-group-10 branch October 20, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentin-boehm valentin-boehm valentin-boehm approved these changes

@chrisknedl chrisknedl chrisknedl approved these changes

@MaximilianAnzinger MaximilianAnzinger MaximilianAnzinger approved these changes

@laadvo laadvo Awaiting requested review from laadvo

Assignees

@DominikRemo DominikRemo

Labels
ready to merge small tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DominikRemo @MaximilianAnzinger @chrisknedl @valentin-boehm