Communication: Hide notifications for active channel on lecture and exercise page

[lennart-keller]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Client

• Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
• I followed the coding and design guidelines.
• Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
• I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.

Motivation and Context

Notifications are shown for the active channel on the lecture/exercise detail pages, even though the channel is open.

Description

Notifications for the open channel are temporarily disabled as long as the sidebar is visible

Steps for Testing

Prerequisites:

• 2 Students
• 1 Course with messaging enabled

1. Go to the same exercise/lecture details page with both students
2. Write messages as student 1
3. Student 2 should see the message, but no notification
4. Go to the messages tab with student 1 and write a message in a different channel (which student 2 is also a member of).
5. Student 2 should see a notification for this

Review Progress

Performance Review

• I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Test Coverage

Client

Class/File	Line Coverage	Confirmation (assert/expect)
discussion-section.component.ts	86.77%	✅
notification.service.ts	75%	✅
notification-settings.service.ts	94.44%	✅

Screenshots

No UI changes

[Kroko-fant]

Tested in a testing session worked as expected

[basak-akan]

Tested in the testing session on TS2, notifications for the open channel disabled 👍

[rstief]

Tested in session on ts2

[MaximilianAnzinger]

Code lgtm

[basak-akan]

Code looks good 👍

[jakubriegel]

This comment is not up to date now

[jakubriegel]

Small note about one comment

[krusche]

can you write some client tests to verify the new behavior

[github-actions]

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

[github-actions]

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

[github-actions]

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.