Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General: Only collapse exercise section when clicking section title #7402

Merged
merged 1 commit into from
Oct 17, 2023
Merged

General: Only collapse exercise section when clicking section title #7402

merged 1 commit into from
Oct 17, 2023

Conversation

florian-glombik
Copy link
Contributor

@florian-glombik florian-glombik commented Oct 16, 2023 •
edited
Loading

Checklist

General

  • I tested all changes and their related features with all corresponding user types on a test server.
  • This is a small issue that I tested locally and was confirmed by another developer on a test server.
  • I chose a title conforming to the naming conventions for pull requests.

Client

  • I added multiple screenshots/screencasts of my UI changes.

Description

Fixes #7400

Steps for Testing

Prerequisites:

  • 1 Students
  • 1 Programming Exercise
  1. Go to the student exercise view (timeframe)
  2. Click on Clone Repository
  3. See that the exercise section does not collapse (see the screencast for the wrong behaviour)

Screenshots

The exercise section should not collapse!

Bildschirmaufnahme.2023-10-16.um.21.45.08.mov

@florian-glombik florian-glombik added client Pull requests that update TypeScript code. (Added Automatically!) bugfix labels Oct 16, 2023
@florian-glombik florian-glombik self-assigned this Oct 16, 2023
@florian-glombik florian-glombik marked this pull request as ready for review October 16, 2023 22:22
@florian-glombik florian-glombik requested a review from a team as a code owner October 16, 2023 22:22
@florian-glombik florian-glombik changed the title General: Only collapse exercise when clicking section title General: Only collapse exercise section when clicking section title Oct 16, 2023
JohannesStoehr
JohannesStoehr approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@JohannesStoehr JohannesStoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. Tested on ts1 and works as excpected

Strohgelaender
Strohgelaender approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code

@krusche krusche added this to the 6.6.1 milestone Oct 17, 2023
@krusche krusche merged commit 94d8430 into develop Oct 17, 2023
@krusche krusche deleted the bugfix/course-exercises/do-not-collapse-on-clicking-exercise branch October 17, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesStoehr JohannesStoehr JohannesStoehr approved these changes

@Strohgelaender Strohgelaender Strohgelaender approved these changes

Assignees

@florian-glombik florian-glombik

Labels
bugfix client Pull requests that update TypeScript code. (Added Automatically!) ready to merge small
Projects
None yet
Milestone
6.6.1
Development

Successfully merging this pull request may close these issues.

Programming exercises: Exercise view collapses when trying to clone
4 participants
@florian-glombik @Strohgelaender @JohannesStoehr @krusche