-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General
: Add missing details to course detail view in course management
#7397
Conversation
src/main/webapp/app/course/manage/detail/course-detail.component.html
Outdated
Show resolved
Hide resolved
src/main/webapp/app/course/manage/detail/course-detail.component.html
Outdated
Show resolved
Hide resolved
src/main/webapp/app/course/manage/detail/course-detail.component.html
Outdated
Show resolved
Hide resolved
src/main/webapp/app/course/manage/detail/course-detail.component.html
Outdated
Show resolved
Hide resolved
Thank you for your feedback, I implemented it, please have another look at the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider only showing the organisation section if there are any assigned to the course
Tested on TS 4, CR approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in testing session - changes mainly looks good to me
ac4a0a9
Your build fails due to a client build error; the server tests also failed, I just reran them to be sure. |
…m/Artemis into chore/course-add-missing-details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on ts1, changes look good
The server tests fail, as soon as that's resolved you can contact me for approval (I've seen that the server tests fail in multiple PRs so maybe its another problem?)
I fixed the client build and since this PR does not include any server changes, I guess the falling tests are not connected to this PR. Please have another look at the PR. |
src/main/webapp/app/course/manage/detail/course-detail.component.html
Outdated
Show resolved
Hide resolved
…m/Artemis into chore/course-add-missing-details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, code looks good now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual tested on legacy ts2. Worked as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual tested on Ts3. Everything works as expected!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm, just one optional (non-blocking) comment:
General
: Add missing details to course detail viewGeneral
: Add missing details to course detail view in course management
Checklist
General
Client
Motivation and Context
There have been some details missing in the course detail page. This PR adds this missing information.
Steps for Testing
Prerequisites:
Review Progress
Performance Review
Code Review
Manual Tests
Screenshots