Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Replace deprecated method call #7395

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Conversation

Strohgelaender
Copy link
Contributor

@Strohgelaender Strohgelaender commented Oct 16, 2023

Checklist

General

Motivation and Context

Replaces a deprecated method call

Description

copyPattern(String) is deprecated in favour of copyPatterns(String...)

Steps for Testing

Create a new PE with static code analysis enabled. Check that issues are correctly reported back to Artemis.

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Screenshots

copy patterns in the newly created build plan:
grafik

@Strohgelaender Strohgelaender requested a review from a team as a code owner October 16, 2023 16:08
@github-actions github-actions bot added the server Pull requests that update Java code. (Added Automatically!) label Oct 16, 2023
Copy link
Contributor

@aplr aplr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

Copy link
Contributor

@tobias-lippert tobias-lippert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

@Strohgelaender Strohgelaender added this to the 6.6.2 milestone Oct 18, 2023
@krusche krusche merged commit 3bc78df into develop Oct 21, 2023
28 of 31 checks passed
@krusche krusche deleted the chore/deprecated-method branch October 21, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge server Pull requests that update Java code. (Added Automatically!) small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants