Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Temporarily replace another documentation link #7394

Closed
wants to merge 1 commit into from
Closed

Development: Temporarily replace another documentation link #7394

wants to merge 1 commit into from

Conversation

timschumi
Copy link

@timschumi timschumi commented Oct 16, 2023

Checklist

General

Motivation and Context

The original documentation server, which this link points to, is down.

Description

This switches the link to point to the GitHub-hosted copy of the documentation instead, similar to all other links in 648f8ec.

Steps for Testing

Prerequisites:

  • 1 web browser
  • 1 text editor (with "clickable links" functionality)
  1. Open the respective file
  2. Click the link
  3. Observe the unresolvable server

Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the contribution.

Copy link
Contributor

@Kroko-fant Kroko-fant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the new link. Looks good to me

@Strohgelaender Strohgelaender changed the title Development: Temporarily replace another documentation link Development: Temporarily replace another documentation link Oct 16, 2023
@Strohgelaender
Copy link
Contributor

#7298 got merged yesterday, so this PR is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants