Development: Add student code of conduct and apso as a static assets
#7390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
server
jakubriegel
changed the title
Development: Development: Add student code of conduct as a static asset
jakubriegel
removed
tests
database
...iarism-cases/instructor-view/detail-view/plagiarism-case-instructor-detail-view.component.ts
Outdated
Show resolved
Hide resolved
Strohgelaender
approved these changes
Oct 16, 2023
...iarism-cases/instructor-view/detail-view/plagiarism-case-instructor-detail-view.component.ts
Show resolved
Hide resolved
jakubriegel
changed the title
Development: Add student code of conduct as a static assetDevelopment: Add student code of conduct and apso as a static assets
b-fein
requested changes
Oct 16, 2023
There was a problem hiding this comment.
The assets should be located in src/main/resources/public like the logo.
Then the existing customisation steps (https://ls1intum.github.io/Artemis/dev/setup/#customize-your-artemis-instance) can be documented and applied as well.
The links to the resources should then be relative to link to the ones of the current Artemis instance rather than the ones from TUM.
|
I can look at it next week |
b-fein
reviewed
Oct 17, 2023
Co-authored-by: Benedikt Fein <[email protected]>
b-fein
approved these changes
Oct 17, 2023
lennart-keller
approved these changes
Oct 17, 2023
|
This PR is stacked and should be merged after #7302 is merged |
krusche
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Motivation and Context
The student code of conduct linked in the template of plagiarism case post and linked in the post created by continuous plagiarism control was no longer available.
Original thread on Slack: https://ls1tum.slack.com/archives/G6TCVL6HL/p1696873741965929.
Description
The student code of conduct is now a static asset of Artemis.
Steps for Testing
Prerequisites:
TEST_SERVER_URL/content/documents/student-code-of-conduct.pdfand check if the PDF loads.Review Progress
Code Review
Manual Tests