`Tutorial groups`: Fix a usability issue when creating new tutorial for campus and language suggestions #7389

max-bergmann · 2023-10-16T12:26:11Z

Checklist

General

I tested all changes and their related features with all corresponding user types on a test server.
Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
I chose a title conforming to the naming conventions for pull requests.

Server

Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
I followed the coding and design guidelines.
I documented the Java code using JavaDoc style.

Client

Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
I followed the coding and design guidelines.
Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
I documented the TypeScript code using JSDoc style.
I added multiple screenshots/screencasts of my UI changes.
I translated all newly inserted strings into English and German.

Motivation and Context

This PR is designed to improve usability when creating tutor groups. The PR offers the default selection of English and German. For the campus search, the default values have been extended. I.e. all possible values of the campus the instructor is involved in are now offered - not only the possibilities of the respective course

Description

fixes #7292

Steps for Testing

Prerequisites:

1 Instructor
2 Courses where the user is instructor
2 Tutor Groups

Log in to Artemis
Navigate to Course Administration
Create one Tutorial --> check whether the default values for english and german are available.
Switch to 2nd course --> create another Tutorial
Check if the previouly inserted campus is visible.
Repeat steps for editing of a tutorial

Review Progress

Performance Review

I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

Code Review 1
Code Review 2

Manual Tests

Test 1
Test 2

Test Coverage

Class/File	Line Coverage	Confirmation (assert/expect)
create-tutorial-group.component.ts	98%	✅

Screenshots

…is registered

Strohgelaender · 2023-10-19T03:01:35Z

src/main/java/de/tum/in/www1/artemis/web/rest/tutorialgroups/TutorialGroupResource.java

@@ -161,7 +162,7 @@ public ResponseEntity<Set<String>> getUniqueLanguageValues(@PathVariable Long co
    public ResponseEntity<List<TutorialGroup>> getAllForCourse(@PathVariable Long courseId) {
        log.debug("REST request to get all tutorial groups of course with id: {}", courseId);
        var course = courseRepository.findByIdElseThrow(courseId);
-        var user = userRepository.getUserWithGroupsAndAuthorities();
+        var user = userRepository.getUser();


The groups are needed in the next call (checkHasAtLeastRoleInCourseElseThrow), which currently leads to an additional database request.

…-creation-of-tutorial

sarpsahinalp

Tested on ts3 the changes seem to be working!

…-creation-of-tutorial

...-groups-management/tutorial-groups/crud/tutorial-group-form/tutorial-group-form.component.ts

JanaNF

Maunal tested on legacy ts2. Worked mostly as expected.

But for the languages: If I added a new language (e.g. Russisch) it did not show up as a default value for the other tutorial (like it did with the locations). I don't know if this is something you want to happen or not. Please let me know.

max-bergmann · 2023-10-29T16:41:39Z

Maunal tested on legacy ts2. Worked mostly as expected.

But for the languages: If I added a new language (e.g. Russisch) it did not show up as a default value for the other tutorial (like it did with the locations). I don't know if this is something you want to happen or not. Please let me know.

Thanks for your review. Originally, the change was only meant for several campuses in different courses, but I have now included the change for the languages as well.

…-creation-of-tutorial

vinceclifford

I reviewed the PR previously with Jana when the selection between German and English was still working.

I tested on TS3 and the requirements (the language selection) were not fulfilled.
Firstly, I can't choose between English and German. There is no drop-down menu. Screenshot of me entering German down below.
Secondly, previous inputs are not "transferred" to different courses. If I select Straubing as the campus in Course1 and then go to Course2, I will not get Straubing recommended. However, if I create another tutorial group in Course1 I will see my previous input. I don't know if this is as it should be.
However, the selection of German and English is not shown to me.

JanaNF

Tested again on ts2. Worked as expected

Co-authored-by: Lucas Welscher <[email protected]>

milljoniaer

Tested ts4, works as expected

Strohgelaender

Please implement my change request above, this currently leads to unneccesary database requests.

…-creation-of-tutorial

vinceclifford

Retested on TS3 during testing session. Works as expected

rstief

Tested on legacy ts3 in testing session.

MaximilianAnzinger

Tested during testing session

lennart-keller

Tested in testing session

florian-glombik

No issues found in testing session on ts3

basak-akan

Tested in testing session worked well

…campus and language suggestions (#7389)

initial commit

e49512e

max-bergmann requested a review from a team as a code owner October 16, 2023 12:26

max-bergmann linked an issue Oct 16, 2023 that may be closed by this pull request

Tutorial: Usability issues in the creation of tutorial. The search text fields does not work as expected. #7292

Closed

github-actions bot assigned max-bergmann Oct 16, 2023

github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Oct 16, 2023

changes for default language & based on all courses where instructor …

abbe7a9

…is registered

github-actions bot added the server Pull requests that update Java code. (Added Automatically!) label Oct 17, 2023

max-bergmann added the bugfix label Oct 17, 2023

Strohgelaender reviewed Oct 19, 2023

View reviewed changes

max-bergmann and others added 3 commits October 19, 2023 15:02

small changes in Language, removed unused methods

81e10ae

Merge branch 'develop' into Tutorial/tutorial-usability-issues-in-the…

25efc4d

…-creation-of-tutorial

Merge branch 'develop' into Tutorial/tutorial-usability-issues-in-the…

8439938

…-creation-of-tutorial

max-bergmann added the ready for review label Oct 24, 2023

sarpsahinalp reviewed Oct 24, 2023

View reviewed changes

Merge branch 'develop' into Tutorial/tutorial-usability-issues-in-the…

b86edd1

…-creation-of-tutorial

Strohgelaender reviewed Oct 28, 2023

View reviewed changes

...-groups-management/tutorial-groups/crud/tutorial-group-form/tutorial-group-form.component.ts Outdated Show resolved Hide resolved

JanaNF requested changes Oct 29, 2023

View reviewed changes

add support for language in all tutorial groups

c4543cf

Merge branch 'develop' into Tutorial/tutorial-usability-issues-in-the…

eeecfc8

…-creation-of-tutorial

max-bergmann requested a review from JanaNF October 29, 2023 16:45

vinceclifford requested changes Oct 29, 2023

View reviewed changes

JanaNF previously approved these changes Oct 29, 2023

View reviewed changes

milljoniaer added the deploy:artemis-test4 label Oct 30, 2023

milljoniaer temporarily deployed to artemis-test4.artemis.cit.tum.de October 30, 2023 15:05 — with GitHub Actions Inactive

github-actions bot removed the deploy:artemis-test4 label Oct 30, 2023

Apply suggestions from code review

09ff1ad

Co-authored-by: Lucas Welscher <[email protected]>

max-bergmann dismissed JanaNF’s stale review via 09ff1ad October 30, 2023 15:06

github-actions bot added the lock:artemis-test4 label Oct 30, 2023

milljoniaer previously approved these changes Oct 30, 2023

View reviewed changes

Strohgelaender requested changes Oct 30, 2023

View reviewed changes

milljoniaer removed the lock:artemis-test4 label Oct 30, 2023

max-bergmann and others added 2 commits October 30, 2023 17:58

Merge branch 'develop' into Tutorial/tutorial-usability-issues-in-the…

5d2dde1

…-creation-of-tutorial

impl. suggested change

d166acf

max-bergmann dismissed milljoniaer’s stale review via d166acf October 30, 2023 17:24

max-bergmann requested review from Strohgelaender and vinceclifford October 30, 2023 17:25

vinceclifford approved these changes Nov 2, 2023

View reviewed changes

rstief approved these changes Nov 2, 2023

View reviewed changes

MaximilianAnzinger approved these changes Nov 2, 2023

View reviewed changes

lennart-keller approved these changes Nov 2, 2023

View reviewed changes

florian-glombik approved these changes Nov 2, 2023

View reviewed changes

basak-akan approved these changes Nov 2, 2023

View reviewed changes

max-bergmann added ready to merge and removed ready for review labels Nov 6, 2023

krusche changed the title ~~Tutorial groups: Usability issue for creating new tutorial for campus and language suggestions~~ Tutorial groups: Fix a usability issue for creating new tutorial for campus and language suggestions Nov 7, 2023

krusche added this to the 6.6.5 milestone Nov 7, 2023

krusche merged commit 8398aa3 into develop Nov 7, 2023
32 of 35 checks passed

krusche deleted the Tutorial/tutorial-usability-issues-in-the-creation-of-tutorial branch November 7, 2023 21:00

krusche changed the title ~~Tutorial groups: Fix a usability issue for creating new tutorial for campus and language suggestions~~ Tutorial groups: Fix a usability issue when creating new tutorial for campus and language suggestions Nov 7, 2023

b-fein pushed a commit that referenced this pull request Nov 13, 2023

Tutorial groups: Fix a usability issue for creating new tutorial for …

58782b6

…campus and language suggestions (#7389)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`Tutorial groups`: Fix a usability issue when creating new tutorial for campus and language suggestions #7389

`Tutorial groups`: Fix a usability issue when creating new tutorial for campus and language suggestions #7389

max-bergmann commented Oct 16, 2023 •

edited

Loading

Strohgelaender Oct 19, 2023

sarpsahinalp left a comment •

edited

Loading

JanaNF left a comment

max-bergmann commented Oct 29, 2023

vinceclifford left a comment

JanaNF left a comment

milljoniaer left a comment

Strohgelaender left a comment

vinceclifford left a comment

rstief left a comment

MaximilianAnzinger left a comment

lennart-keller left a comment

florian-glombik left a comment

basak-akan left a comment

Tutorial groups: Fix a usability issue when creating new tutorial for campus and language suggestions #7389

Tutorial groups: Fix a usability issue when creating new tutorial for campus and language suggestions #7389

Conversation

max-bergmann commented Oct 16, 2023 • edited Loading

Checklist

General

Server

Client

Motivation and Context

Description

Steps for Testing

Review Progress

Performance Review

Code Review

Manual Tests

Test Coverage

Screenshots

Strohgelaender Oct 19, 2023

Choose a reason for hiding this comment

sarpsahinalp left a comment • edited Loading

Choose a reason for hiding this comment

JanaNF left a comment

Choose a reason for hiding this comment

max-bergmann commented Oct 29, 2023

vinceclifford left a comment

Choose a reason for hiding this comment

JanaNF left a comment

Choose a reason for hiding this comment

milljoniaer left a comment

Choose a reason for hiding this comment

Strohgelaender left a comment

Choose a reason for hiding this comment

vinceclifford left a comment

Choose a reason for hiding this comment

rstief left a comment

Choose a reason for hiding this comment

MaximilianAnzinger left a comment

Choose a reason for hiding this comment

lennart-keller left a comment

Choose a reason for hiding this comment

florian-glombik left a comment

Choose a reason for hiding this comment

basak-akan left a comment

Choose a reason for hiding this comment

`Tutorial groups`: Fix a usability issue when creating new tutorial for campus and language suggestions #7389

`Tutorial groups`: Fix a usability issue when creating new tutorial for campus and language suggestions #7389

max-bergmann commented Oct 16, 2023 •

edited

Loading

sarpsahinalp left a comment •

edited

Loading