-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General
: Make markdown editor resizable by default
#7386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Tested on Legacy TS1 |
The markdown editors don't have the resize icon in the bottom right corner like the native textareas have it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in testing session - LGTM
Tested on TS4, works |
Checklist
General
Client
Motivation and Context
This PR closes #7385. Default behavior should be resizable markdown editors (it can still be disabled with
enableResize=false
).This PR also removes unnecessary on-top built resizing for programming instruction editor.
Steps for Testing
Look for markdown editors and verify that they are resizable and look/work correctly, especially for:
Review Progress
Code Review
Manual Tests
Test Coverage
Screenshots
programming exercise instructions:
course code of conduct: