Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Make markdown editor resizable by default #7386

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

milljoniaer
Copy link
Contributor

@milljoniaer milljoniaer commented Oct 16, 2023

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I followed the coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

This PR closes #7385. Default behavior should be resizable markdown editors (it can still be disabled with enableResize=false).
This PR also removes unnecessary on-top built resizing for programming instruction editor.

Steps for Testing

Look for markdown editors and verify that they are resizable and look/work correctly, especially for:

  • Programming instructions editor (edit/create new programming exercise)
  • Code of Conduct/Registration Confirmation Message (edit/create course)

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

Screenshots

programming exercise instructions:
image
course code of conduct:
image

@milljoniaer milljoniaer requested a review from a team as a code owner October 16, 2023 10:02
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Oct 16, 2023
Copy link
Contributor

@aplr aplr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

Copy link
Contributor

@valentin-boehm valentin-boehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xHadie
Copy link

xHadie commented Oct 18, 2023

Tested on Legacy TS1
No Markdown editors appear to be resizeable by default for me. I never see the resize icon in the border of the containers.

@milljoniaer
Copy link
Contributor Author

Tested on Legacy TS1 No Markdown editors appear to be resizeable by default for me. I never see the resize icon in the border of the containers.

The markdown editors don't have the resize icon in the bottom right corner like the native textareas have it.
They have it below the editor in the center. You can see it in the screenshot of my PR description.

@milljoniaer milljoniaer temporarily deployed to artemis-test4.artemis.cit.tum.de October 19, 2023 10:08 — with GitHub Actions Inactive
Copy link
Contributor

@max-bergmann max-bergmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in testing session - LGTM

@julian-christl
Copy link
Member

Tested on TS4, works

@krusche krusche added this to the 6.6.2 milestone Oct 21, 2023
@krusche krusche merged commit d8261f6 into develop Oct 21, 2023
@krusche krusche deleted the feat/make-resizable-markdown-default branch October 21, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General: Textareas are not resizable during course creation
7 participants