Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Fix deprecated configuration in jest.config.js #7375

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

aplr
Copy link
Contributor

@aplr aplr commented Oct 14, 2023

Checklist

General

Motivation and Context

When running tests, the following warning appeared, often several times, which clutters the test output:

ts-jest[ts-jest-transformer] (WARN) Define `ts-jest` config under `globals` is deprecated. Please do
transform: {
    <transform_regex>: ['ts-jest', { /* ts-jest config goes here in Jest */ }],
},

Description

As suggested by the warning and in the docs for jest-preset-angular, the ts-jest options were now moved from the global ts-jest configuration to the jest-preset-angular transform.

Steps for Testing

  1. Run tests
  2. No warnings
  3. Tests succeed

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

@aplr aplr marked this pull request as ready for review October 14, 2023 12:09
@aplr aplr requested a review from a team as a code owner October 14, 2023 12:09
@krusche krusche added this to the 6.6.0 milestone Oct 14, 2023
@krusche krusche merged commit 5273ccb into develop Oct 14, 2023
16 of 21 checks passed
@krusche krusche deleted the development/remove-ts-jest-warning branch October 14, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants