-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General
: Add new contributors to about us page
#7371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on ts3 all new additions are there and page looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some images are too large, please provide smaller versions
4af0f62
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated links work and changes overall look good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested on TS3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on ts3 with Vincent Clifford. Images all look great and are displayed correctly
General
: Add contributors to about us pageGeneral
: Add new contributors to about us page
Checklist
General
Motivation and Context
Adds new contributors to the about us page.
How to add yourself
chore/about-us
branch locallysrc/main/resources/public/content/about-us.json
fullName
for your namesortBy
if the automatic sorting does not detect your last name correctly (if your name consists of mulitple words)public/images/about
directory and link that image using thephotoDirectory
key. Make sure to use a square, otherwise crop your image before uploading it.Steps for Testing
View the about us page and check that the new contributors are visible and sorted.