Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Add new contributors to about us page #7371

Merged
merged 15 commits into from
Nov 10, 2023
Merged

Conversation

MaximilianAnzinger
Copy link
Collaborator

@MaximilianAnzinger MaximilianAnzinger commented Oct 14, 2023

Checklist

General

Motivation and Context

Adds new contributors to the about us page.

How to add yourself

  1. Checkout the chore/about-us branch locally
  2. Add yourself to this file: src/main/resources/public/content/about-us.json
  • Use fullName for your name
  • Use sortBy if the automatic sorting does not detect your last name correctly (if your name consists of mulitple words)
  1. Add your image to the public/images/about directory and link that image using the photoDirectory key. Make sure to use a square, otherwise crop your image before uploading it.
  2. Make sure the file has at most 100KB

Steps for Testing

View the about us page and check that the new contributors are visible and sorted.

@MaximilianAnzinger MaximilianAnzinger marked this pull request as ready for review October 26, 2023 18:58
@MaximilianAnzinger MaximilianAnzinger requested a review from a team as a code owner October 26, 2023 18:58
vinceclifford
vinceclifford previously approved these changes Nov 2, 2023
Copy link

@vinceclifford vinceclifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

rstief
rstief previously approved these changes Nov 2, 2023
Copy link
Contributor

@rstief rstief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ts3 all new additions are there and page looks good.

Copy link
Member

@krusche krusche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some images are too large, please provide smaller versions

Copy link
Contributor

@JohannesStoehr JohannesStoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated links work and changes overall look good!

Copy link

@vinceclifford vinceclifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on TS3

Copy link

@Predixx Predixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ts3 with Vincent Clifford. Images all look great and are displayed correctly

@krusche krusche changed the title General: Add contributors to about us page General: Add new contributors to about us page Nov 10, 2023
@krusche krusche added this to the 6.6.5 milestone Nov 10, 2023
@krusche krusche merged commit 32cef8f into develop Nov 10, 2023
45 of 50 checks passed
@krusche krusche deleted the chore/about-us branch November 10, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.