Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development: Fix lti profile for client #7361

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Development: Fix lti profile for client #7361

merged 1 commit into from
Oct 14, 2023

Conversation

basak-akan
Copy link
Contributor

@basak-akan basak-akan commented Oct 12, 2023 •
edited
Loading

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I followed the coding and design guidelines.

Motivation and Context

Toggle the LTI feature through spring profiles.

Description

LTI profile constant is defined for client and LTI-related functionality checks only for lti profile.

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Oct 12, 2023
@basak-akan basak-akan marked this pull request as ready for review October 12, 2023 08:44
@basak-akan basak-akan requested a review from a team as a code owner October 12, 2023 08:44
Hialus
Hialus approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@Hialus Hialus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍🏻

Strohgelaender
Strohgelaender approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code

florian-glombik
florian-glombik approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@florian-glombik florian-glombik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine

@krusche krusche added this to the 6.6.0 milestone Oct 14, 2023
@krusche krusche merged commit 726f7ce into develop Oct 14, 2023
30 of 33 checks passed
@krusche krusche deleted the bugfix/fix-lti-profile branch October 14, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-fein b-fein b-fein approved these changes

@florian-glombik florian-glombik florian-glombik approved these changes

@Strohgelaender Strohgelaender Strohgelaender approved these changes

@Hialus Hialus Hialus approved these changes

Assignees

@basak-akan basak-akan

Labels
client Pull requests that update TypeScript code. (Added Automatically!) ready to merge
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.
6 participants
@basak-akan @Hialus @Strohgelaender @florian-glombik @b-fein @krusche