-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programming exercises
: Fix display of long feedback details and submission count in exams
#7348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (I included the same fix in #7015 :) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 👍
General
: Fix fetching of long feedbackGeneral
: Fix display of long feedback details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
4ef6376
General
: Fix display of long feedback detailsProgramming exercises
: Fix display of long feedback details and submission count in exams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 👍
Thanks for @Strohgelaender for the new tests |
Checklist
General
Server
Motivation and Context
The
FeedbackDTO
did not contain the ID of the feedback. This causes that in the feedback detail view a potential long feedback can no longer be fetched, since the ID of the feedback it belongs to is required to construct the URL and know on the server which feedback should be fetched.Currently it tries to fetch the long feedback from an URL like
https://ARTEMIS/api/results/123456789/feedbacks/undefined/long-feedback
which fails since
undefined
is not a valid id.Description
Adds the ID of the feedback to the DTO.
Then the feedback can be fetched from the server again.
Steps for Testing
Prerequisites:
fail("abc".repeat(10_000))
method call inside.Review Progress
Code Review
Manual Tests