Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development: Document exam exercise submission policies #7340

Merged
merged 20 commits into from
Oct 21, 2023
Merged

Development: Document exam exercise submission policies #7340

merged 20 commits into from
Oct 21, 2023

Conversation

terlan98
Copy link
Contributor

@terlan98 terlan98 commented Oct 8, 2023 •
edited
Loading

Checklist

General

Motivation and Context

Document changes implemented in #7128

Description

Added documentation for students and instructors.

Steps for Testing

  1. Read the exam mode docs: https://artemis-platform--7340.org.readthedocs.build/en/7340/user/exam_mode.html
  2. Read the exam mode features page: {test-server-url}/features/instructors

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

@terlan98 terlan98 changed the title Development: Document exam exercise submission policies Development: Document exam exercise submission policies Oct 8, 2023
@terlan98 terlan98 marked this pull request as ready for review October 8, 2023 20:41
@terlan98 terlan98 requested a review from a team as a code owner October 8, 2023 20:41
Strohgelaender
Strohgelaender previously approved these changes Oct 9, 2023
View reviewed changes
b-fein
b-fein previously approved these changes Oct 10, 2023
View reviewed changes
krusche
krusche requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@krusche krusche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also mention this feature on the website https://artemis.in.tum.de/features/instructors ?

@terlan98 terlan98 dismissed stale reviews from b-fein and Strohgelaender via 1c01516 October 11, 2023 20:01
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Oct 11, 2023
b-fein
b-fein reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@b-fein b-fein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I’ve got a few suggestions for the German translation, though.

src/main/webapp/i18n/de/featureOverview.json Outdated Show resolved Hide resolved
terlan98 and others added 3 commits October 14, 2023 11:13
@terlan98 @b-fein
Fix German translation
b74abb5 
Co-authored-by: Benedikt Fein <[email protected]>
@terlan98
Adjust English translation
8f3d250
@terlan98
Merge branch 'develop' of https://github.com/ls1intum/Artemis into do…
df62d20 
…cumentation/exam-exercise-submission-policy

# Conflicts:
#	src/main/webapp/app/feature-overview/feature-overview.component.ts
#	src/main/webapp/i18n/de/featureOverview.json
#	src/main/webapp/i18n/en/featureOverview.json
b-fein
b-fein previously approved these changes Oct 14, 2023
View reviewed changes
@terlan98 terlan98 requested a review from b-fein October 14, 2023 07:34
@github-actions github-actions bot added deployment-error Added by deployment workflows if an error occured and removed deploy:artemis-test3 labels Oct 19, 2023
@LenaKahle LenaKahle added lock:artemis-test7 and removed deployment-error Added by deployment workflows if an error occured labels Oct 19, 2023
LenaKahle
LenaKahle approved these changes Oct 19, 2023
View reviewed changes
Copy link

@LenaKahle LenaKahle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@krusche krusche added this to the 6.6.2 milestone Oct 21, 2023
@krusche krusche merged commit 5bd2ef4 into develop Oct 21, 2023
19 of 23 checks passed
@krusche krusche deleted the documentation/exam-exercise-submission-policy branch October 21, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-fein b-fein b-fein approved these changes

@LenaKahle LenaKahle LenaKahle approved these changes

@krusche krusche Awaiting requested review from krusche

@Strohgelaender Strohgelaender Awaiting requested review from Strohgelaender

Assignees

@terlan98 terlan98

Labels
client Pull requests that update TypeScript code. (Added Automatically!) documentation ready to merge
Projects
None yet
Milestone
6.6.2
Development

Successfully merging this pull request may close these issues.
5 participants
@terlan98 @krusche @Strohgelaender @LenaKahle @b-fein