Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development: Add documentation for lecture unit processing #7310

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Development: Add documentation for lecture unit processing #7310

merged 6 commits into from
Oct 10, 2023

Conversation

pellumbbaboci
Copy link
Contributor

@pellumbbaboci pellumbbaboci commented Oct 3, 2023 •
edited
Loading

Checklist

General

Motivation and Context

Missing documentation about lecture attachment unit processing.

Description

Added documentation about attachment unit processing with their corresponding screenshots.

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

@pellumbbaboci pellumbbaboci marked this pull request as ready for review October 5, 2023 22:45
@pellumbbaboci pellumbbaboci requested a review from a team as a code owner October 5, 2023 22:45
lennart-keller
lennart-keller reviewed Oct 6, 2023
View reviewed changes
Copy link
Contributor

@lennart-keller lennart-keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc looks good, added a few suggestions.

docs/user/lectures.rst Outdated Show resolved Hide resolved
docs/user/lectures.rst Outdated Show resolved Hide resolved
docs/user/lectures.rst Outdated Show resolved Hide resolved
lennart-keller
lennart-keller previously approved these changes Oct 6, 2023
View reviewed changes
nityanandaz
nityanandaz reviewed Oct 6, 2023
View reviewed changes
Copy link
Contributor

@nityanandaz nityanandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads nicely

docs/user/lectures.rst Outdated Show resolved Hide resolved
docs/user/lectures.rst Outdated Show resolved Hide resolved
jakubriegel
jakubriegel reviewed Oct 7, 2023
View reviewed changes
Copy link
Contributor

@jakubriegel jakubriegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. I agree with @nityanandaz comments

lennart-keller
lennart-keller approved these changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@lennart-keller lennart-keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for incorporating my suggestions

@nityanandaz nityanandaz changed the title Development : Add documentation for lecture unit processing Development: Add documentation for lecture unit processing Oct 7, 2023
@krusche krusche added this to the 6.6.0 milestone Oct 10, 2023
@krusche krusche merged commit e672f06 into develop Oct 10, 2023
5 checks passed
@krusche krusche deleted the documentation/process-lecture-units branch October 10, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lennart-keller lennart-keller lennart-keller approved these changes

@jakubriegel jakubriegel jakubriegel approved these changes

@nityanandaz nityanandaz nityanandaz approved these changes

Assignees

@pellumbbaboci pellumbbaboci

Labels
documentation ready for review
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pellumbbaboci @nityanandaz @jakubriegel @lennart-keller @krusche