Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iris: Add new session and message content endpoints #7301

Conversation

RY997
Copy link
Contributor

@RY997 RY997 commented Oct 2, 2023

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
  • I followed the coding and design guidelines.
  • I added multiple integration tests (Spring) related to the features (with a high test coverage).
  • I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
  • I documented the Java code using JavaDoc style.

Changes affecting Programming Exercises

  • I tested all changes and their related features with all corresponding user types on Test Server 1 (Atlassian Suite).
  • I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context

For the new type of session and message, we need the corresponding endpoints.

Description

The main files changed which are highly related to the topic**: IrisCodeEditorSessionResource, IrisCodeEditorMessageResource, IrisCodeEditorSessionIntegration and IrisCodeEditorMessageIntegration.

Other files changed are because of formatting.

Steps for Testing

Exam Mode Testing

Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Test Coverage

Class/File Line Coverage Confirmation (assert/expect)
IrisCodeEditorSessionResource.java 80%
IrisCodeEditorMessageResource.java 71%

Some overlap methods are tested in other class

Screenshots

@github-actions github-actions bot added tests server Pull requests that update Java code. (Added Automatically!) labels Oct 2, 2023
@RY997 RY997 marked this pull request as ready for review October 5, 2023 16:23
@RY997 RY997 requested a review from a team as a code owner October 5, 2023 16:23
@RY997 RY997 marked this pull request as draft October 11, 2023 07:30
@RY997 RY997 marked this pull request as ready for review October 11, 2023 12:14
@RY997 RY997 added component:Iris deploy:artemis-test9 Testserver for Project Theia labels Oct 13, 2023
@RY997 RY997 temporarily deployed to artemis-test9.artemis.cit.tum.de October 13, 2023 10:53 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:artemis-test9 and removed deploy:artemis-test9 Testserver for Project Theia labels Oct 13, 2023
@github-actions
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@RY997 RY997 closed this Oct 28, 2023
@krusche krusche deleted the feature/iris-update-component-plan-content-endpoint branch April 22, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:Iris server Pull requests that update Java code. (Added Automatically!) stale tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant