Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming exercises: Change Button Labels and add support for Local Testing and Feedback Mode #7214

Closed
wants to merge 53 commits into from

Conversation

Kroko-fant
Copy link
Contributor

@Kroko-fant Kroko-fant commented Sep 17, 2023

Checklist

General

Server

-> no server changes made

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I followed the coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Changes affecting Programming Exercises

  • I tested all changes and their related features with all corresponding user types on Test Server 1 (Atlassian Suite).
  • I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context

ls1intum/Orion#93

Description

Orion has received a patch that allows the usage of more IDEs next to IntelliJ. Therefore some of the Button labels weren't up to date anymore.
Furthermore Orion gets an update where students can view inline feedback directly in their IDE. For that a new Reload Button is introduced

Steps for Testing

In Artemis:

  1. Open a programming exercise! no extra button should be there

In Orion

  1. Open a programming exercise
  2. Test if the buttons are all appearing
    2.1. Start assessment button
    2.2. Open in your IDE button
    2.3. Submit

No changes for Tutor buttons but they still should be visible

Without orion, all orion buttons should not be visible. (can be tested with a normal webbrowser)

Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Test Coverage

Screenshots

grafik

grafik

@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Sep 17, 2023
@github-actions github-actions bot added the tests label Sep 17, 2023
@Kroko-fant Kroko-fant temporarily deployed to artemis-test6.artemis.cit.tum.de September 17, 2023 22:32 — with GitHub Actions Inactive
@ls1intum ls1intum deleted a comment from github-actions bot Sep 18, 2023
@github-actions github-actions bot added the deployment-error Added by deployment workflows if an error occured label Sep 18, 2023
@Kroko-fant Kroko-fant added deploy:artemis-test6 and removed deployment-error Added by deployment workflows if an error occured labels Sep 18, 2023
@github-actions github-actions bot added deployment-error Added by deployment workflows if an error occured and removed deploy:artemis-test6 labels Sep 18, 2023
@ls1intum ls1intum deleted a comment from github-actions bot Sep 18, 2023
@Kroko-fant Kroko-fant added deploy:artemis-test6 and removed deployment-error Added by deployment workflows if an error occured labels Sep 18, 2023
Copy link

github-actions bot commented Dec 2, 2023

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@krusche krusche closed this Dec 9, 2023
@krusche krusche deleted the development/orion-feedback branch April 22, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants