Communication: Accept messaging code of conduct
#7154
Teamscale
This pull request would introduce 11 new findings
Details
- src/test/java/de/tum/in/www1/artemis/metis/ConversationIntegrationTest.java#457: Method
responsibleUsers_shouldReturnCorrectValueviolates naming convention. Should be one of[a-z][a-zA-Z0-9]*(view in Teamscale) - src/test/java/de/tum/in/www1/artemis/metis/ConversationIntegrationTest.java#17: Star import of
de.tum.in.www1.artemis.domain.*should not be used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/web/rest/metis/conversation/ConversationResource.java#3: Star import of
java.util.*should not be used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/domain/ConductAgreement.java#5: Star import of
javax.persistence.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/metis/ConversationIntegrationTest.java#437: Method
codeOfConduct_isAcceptedviolates naming convention. Should be one of[a-z][a-zA-Z0-9]*(view in Teamscale) - src/main/java/de/tum/in/www1/artemis/domain/ConductAgreementId.java#24: Clone with 2 instances of length 13 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/domain/ConductAgreement.java#28: Clone with 2 instances of length 13 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/messaging/InstanceMessageReceiveService.java#293: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/metis/ConversationIntegrationTest.java#444: Method
codeOfConduct_acceptviolates naming convention. Should be one of[a-z][a-zA-Z0-9]*(view in Teamscale) - src/main/java/de/tum/in/www1/artemis/service/programming/ProgrammingExerciseService.java#69: Comment should not contain
//(view in Teamscale) - src/main/java/de/tum/in/www1/artemis/service/programming/ProgrammingExerciseService.java#62: Comment should not contain
//(view in Teamscale)
Annotations
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/metis/ConversationIntegrationTest.java#L437
Method `codeOfConduct_isAccepted` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=7085%2Fv2%2Faccept-messaging-code-of-conduct%3AHEAD&id=120B355BDC579EAD7834B4502A27C35C
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/metis/ConversationIntegrationTest.java#L17
Star import of `de.tum.in.www1.artemis.domain.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=7085%2Fv2%2Faccept-messaging-code-of-conduct%3AHEAD&id=549F645D137AB082341769FD2B6DB532
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/metis/ConversationIntegrationTest.java#L444
Method `codeOfConduct_accept` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=7085%2Fv2%2Faccept-messaging-code-of-conduct%3AHEAD&id=C3258F9BF36325330B2EA7324A980C43
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/metis/ConversationIntegrationTest.java#L457
Method `responsibleUsers_shouldReturnCorrectValue` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=7085%2Fv2%2Faccept-messaging-code-of-conduct%3AHEAD&id=EE630CDC455FFB923061524636E28924
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/web/rest/metis/conversation/ConversationResource.java#L3
Star import of `java.util.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=7085%2Fv2%2Faccept-messaging-code-of-conduct%3AHEAD&id=7AB748D3663E46FE52A1E7C9E5BB6F30
Check warning on line 5 in src/main/java/de/tum/in/www1/artemis/domain/ConductAgreement.java
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/domain/ConductAgreement.java#L5
Star import of `javax.persistence.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=7085%2Fv2%2Faccept-messaging-code-of-conduct%3AHEAD&id=73CBF151DD61434070A871688F7E4E3A
Check warning on line 51 in src/main/java/de/tum/in/www1/artemis/domain/ConductAgreement.java
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/domain/ConductAgreement.java#L28-L51
Clone with 2 instances of length 13
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=7085%2Fv2%2Faccept-messaging-code-of-conduct%3AHEAD&id=DB384D0BEA5385E7067C11DBAAE05618
Check warning on line 47 in src/main/java/de/tum/in/www1/artemis/domain/ConductAgreementId.java
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/domain/ConductAgreementId.java#L24-L47
Clone with 2 instances of length 13
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=7085%2Fv2%2Faccept-messaging-code-of-conduct%3AHEAD&id=BBE2B719848B9BE214787456E237AF76